Conversational search by korgon · Pull Request #160 · searchspring/snap-1.0

korgon · 2026-01-07T15:50:51Z

under active development - DO NOT MERGE

…oad, more wip

…hat sessions, added persistence and improved the UI

…ponse must be used (using header for now)

…fying product attachment to contain image and name

refactor(chat): moving stuff around and fixing some bugs

Copilot

Pull request overview

This PR introduces conversational search functionality through a new Chat feature. The implementation includes a complete chat interface with support for image uploads, product attachments, and AI-powered responses.

Key Changes:

Added ChatController, ChatStore, and ChatSessionStore for managing chat state and interactions
Integrated chat API client with support for various request types (general, product query, image search, etc.)
Created Chat UI components with message display, attachments, and feedback mechanisms

Reviewed changes

Copilot reviewed 42 out of 43 changed files in this pull request and generated 14 comments.

Show a summary per file

File	Description
packages/snap-store-mobx/src/types.ts	Added ChatStoreConfig types and integrated into StoreConfigs union
packages/snap-store-mobx/src/Chat/ChatStore.ts	Implements main chat store with session management and storage
packages/snap-store-mobx/src/Chat/Stores/ChatSessionStore.ts	Manages individual chat sessions with message history and attachments
packages/snap-store-mobx/src/Chat/Stores/ChatAttachmentStore.ts	Handles image and product attachments with state management
packages/snap-controller/src/Chat/ChatController.ts	Controller implementation for chat interactions and API requests
packages/snap-preact/src/Templates/SnapTemplates.tsx	Integrates chat targets and configuration into template system
packages/snap-preact/components/src/components/Organisms/Chat/Chat.tsx	Main chat UI component with message display and input
packages/snap-client/src/Client/apis/Chat.ts	API client for chat endpoints including message sending and image upload
packages/snap-client/src/Client/transforms/chatResponse.ts	Transforms chat API responses to standardized format
.github/workflows/test.yml	Temporarily disabled tests (commented out)

Comments suppressed due to low confidence (1)

packages/snap-controller/src/Chat/ChatController.ts:1

Corrected spelling of 'transfrorm respose' to 'transform response'.

/*

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-01-07T15:52:46Z

packages/snap-preact/components/src/components/Organisms/Chat/Chat.tsx

+		treePath: globalTreePath,
+	};
+
+	let props = mergeProps('facets', globalTheme, defaultProps, properties);


The first argument should be 'chat' instead of 'facets' to correctly identify the component type for props merging.

Suggested change

let props = mergeProps('facets', globalTheme, defaultProps, properties);

let props = mergeProps('chat', globalTheme, defaultProps, properties);

Copilot · 2026-01-07T15:52:46Z

packages/snap-client/src/Client/apis/Abstract.ts

+
+			if (sessionId) {
+				// @ts-ignore - add sessionId to response context
+				responseJSON.context = response.context || { sessionId };


Attempting to assign to response.context but should be responseJSON.context. The current code creates the context object correctly but the comment suggests confusion about the source.

Suggested change

responseJSON.context = response.context || { sessionId };

responseJSON.context = responseJSON.context || { sessionId };

Copilot · 2026-01-07T15:52:46Z

packages/snap-client/src/Client/apis/Chat.ts

+
+	async postUploadImage(requestParameters: UploadImageRequestModel): Promise<UploadImageResponseModel> {
+		const headerParameters: HTTPHeaders = {
+			'X-Widget-Id': 'test-ss-demo',


Hard-coded widget ID should be passed as a parameter instead. This makes the upload functionality non-functional for other widgets and creates a security risk by exposing test credentials.

Copilot · 2026-01-07T15:52:47Z

.github/workflows/test.yml

+      # - name: Tests
+      #   env:
+      #     NODE_OPTIONS: "--max-old-space-size=4096"
+      #   run: npm run test


Tests have been commented out in CI. This should be re-enabled before merging to ensure code quality and prevent regressions.

Suggested change

# - name: Tests

# env:

# NODE_OPTIONS: "--max-old-space-size=4096"

# run: npm run test

- name: Tests

env:

NODE_OPTIONS: "--max-old-space-size=4096"

run: npm run test

Copilot · 2026-01-07T15:52:47Z

packages/snap-store-mobx/src/Chat/Stores/ChatAttachmentStore.ts

+};
+
+export class ChatAttachmentProduct extends ChatAttachment {
+	public type: 'product' | never = 'product';


The union with 'never' is redundant. The type should simply be 'product' as a literal type.

Copilot · 2026-01-07T15:52:49Z

packages/snap-preact/components/src/components/Organisms/Chat/Attachment.tsx

+		) : (
+			<></>
+		);
+	} else if (type == 'product') {


Use strict equality (===) instead of loose equality (==) for type comparisons.

Copilot · 2026-01-07T15:52:49Z

packages/snap-store-mobx/src/Chat/Stores/ChatSessionStore.ts

+			const attachments: string[] = [];
+			if (request.data.requestType === 'imageSearch') {
+				const imageId = request.data.attachedImageId;
+				const attachedImage = this.attachments.attached.find((item) => item.type == 'image' && item.imageId == imageId);


Use strict equality (===) instead of loose equality (==) for type and ID comparisons.

Copilot · 2026-01-07T15:52:49Z

packages/snap-store-mobx/src/Chat/Stores/ChatSessionStore.ts

+
+			if (request.data.requestType === 'productQuery') {
+				const productId = request.data.productId;
+				const attachedImage = this.attachments.attached.find((item) => item.type == 'product' && item.productId == productId);


Use strict equality (===) instead of loose equality (==) for type and ID comparisons.

Copilot · 2026-01-07T15:52:49Z

packages/snap-preact/components/src/components/Organisms/Chat/Chat.tsx

+}
+
+export interface MessageProps {
+	chatItem: any;


Replace any type with the proper ChatMessage type that's imported in the file for better type safety.

Copilot · 2026-01-07T15:52:50Z

packages/snap-store-mobx/src/Chat/ChatStore.ts

+	public storage: StorageStore;
+	public chats: ChatSessionStore[] = [];
+	public currentChatId: string;
+	public quickViewResult: any = {};


Replace any type with Product | null or similar appropriate type for better type safety.

Suggested change

public quickViewResult: any = {};

public quickViewResult: ChatAttachmentProduct | null = null;

… config

… changes

…tons, add productSimilar

… titles

fix: productSimilar fix and sends chat message, general styling, icon…

… fit styles

…urations

…ations where display may not be defined

dkonieczek and others added 16 commits December 23, 2025 11:45

fix: wip

9a80d81

fix: conversational search wip

7d83216

refactor: rename conversational search to chat, add initial image upl…

18b0c5e

…oad, more wip

refactor: wip - working state

5b95eee

refactor: more progress

7ac684f

refactor(snap/chat): added more response types, refactored to multi-c…

86d9df9

…hat sessions, added persistence and improved the UI

refactor(controller/chat): adding sessionId for chats since API res…

73abb84

…ponse must be used (using header for now)

chore: add productQuery attachment

089c92e

refactor(controller/chat): updating stores with safety logic and modi…

43aae98

…fying product attachment to contain image and name

chore: add questions section

1743f91

refactor: add feedback

78c7628

refactor(chat): moving stuff around and fixing some bugs

7b6cf6e

refactor(withtracking): uno

c305f81

Merge pull request #159 from searchspring/conv-search-refactor

6627e23

refactor(chat): moving stuff around and fixing some bugs

feat(preact/templates): adding support for chat in templates

d8f922a

build(test): skipping testing in the test workflow for now

21734cc

Copilot AI review requested due to automatic review settings January 7, 2026 15:50

Copilot AI reviewed Jan 7, 2026

View reviewed changes

Merge branch 'develop' into conversational-search

81e765b

korgon marked this pull request as draft January 7, 2026 16:33

korgon and others added 10 commits January 7, 2026 10:38

feat(preact/templates): adding ability to specify "mode" in templates…

24d36b8

… config

feat: add facet filters, chat history

995de98

feat: add initChat

37e54ba

feat: improve history view, add icons, fix feedback state, show errors

6da2159

fix(chat): adjusting image-upload request model and adjusting actions…

d08f0e4

… changes

refactor: styling improvements

7f66f5b

fix: add slidesPerGroup

b1064f7

chore: wip

2ac2b73

refactor(chat): fixing a few issues and cleaning up the UI a bit

f3284e3

chore: cleanup exports, table styles, facet actions styles

68044c7

dkonieczek and others added 12 commits January 13, 2026 15:58

refactor: add autocomplete chat open button, refactor result card but…

6ef5731

…tons, add productSimilar

fix: productSimilar fix and sends chat message, general styling, icon…

e902641

… titles

Merge pull request #164 from searchspring/dennis/conversational-search

cb34512

fix: productSimilar fix and sends chat message, general styling, icon…

refactor: add discussProduct event and modify demostore result card

21e64c4

refactor: use custom result card for autocomplete

447297f

refactor(preact/components/chat): updating styling and refactoring to…

87382a4

… fit styles

Merge branch 'develop' into conversational-search

c75db89

fix(chat): adding some animations and ability to inject anywhere

14b1156

Merge branch 'develop' into conversational-search

2ef5c3f

adjusting animations - adding getContext for supporting custom config…

b886f1c

…urations

fix(preact/components/calloutbadge): added an optional chain for situ…

bf763e6

…ations where display may not be defined

Merge branch 'develop' into conversational-search

829e9ae

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comments

Conversational search#160

Conversational search#160
korgon wants to merge 39 commits intodevelopfrom
conversational-search

korgon commented Jan 7, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Jan 7, 2026

Uh oh!

Copilot AI Jan 7, 2026

Uh oh!

Copilot AI Jan 7, 2026

Uh oh!

Copilot AI Jan 7, 2026

Uh oh!

Copilot AI Jan 7, 2026

Uh oh!

Copilot AI Jan 7, 2026

Uh oh!

Copilot AI Jan 7, 2026

Uh oh!

Copilot AI Jan 7, 2026

Uh oh!

Copilot AI Jan 7, 2026

Uh oh!

Copilot AI Jan 7, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

	let props = mergeProps('facets', globalTheme, defaultProps, properties);
	let props = mergeProps('chat', globalTheme, defaultProps, properties);

	responseJSON.context = response.context \|\| { sessionId };
	responseJSON.context = responseJSON.context \|\| { sessionId };

	public quickViewResult: any = {};
	public quickViewResult: ChatAttachmentProduct \| null = null;

Comments

Conversation

korgon commented Jan 7, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Jan 7, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 7, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 7, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 7, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 7, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 7, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 7, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 7, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 7, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 7, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants