refactor(initiator): refactor initiator code#158
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR refactors how the initiator/framework identifier is tracked throughout the system. The changes replace the old initiator property-based approach with a cleaner managed flag pattern, and updates the tracker to use "athos" as the product identifier instead of "searchspring".
Key changes:
- Replaced dynamic initiator detection with a boolean
managedflag for clearer intent - Updated the tracker's product identifier from "searchspring" to "athos"
- Standardized the framework path format to use
managed/snap/preactorsnap/preact
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| packages/snap-tracker/src/Tracker.ts | Changed product identifier from "searchspring" to "athos" in initiator string |
| packages/snap-preact/src/Snap.tsx | Replaced initiator property detection with managed flag, updated framework path construction |
| packages/snap-preact-demo/templates/webpack.modern.js | Updated webpack entry point to use modern.ts |
| packages/snap-preact-demo/templates/src/universal.ts | Added searchspring.managed flag instead of using initiator property |
| packages/snap-preact-demo/templates/src/modern.ts | Created new entry file that sets managed flag |
| packages/snap-preact-demo/snap/webpack.modern.js | Updated webpack entry point to use modern.ts |
| packages/snap-preact-demo/snap/src/universal.ts | Replaced initiator property with managed flag |
| packages/snap-preact-demo/snap/src/modern.ts | Replaced initiator property with managed flag |
| .eslintignore | Added webpack.modern.js files to eslint ignore list |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
korgon
reviewed
Jan 7, 2026
korgon
approved these changes
Jan 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.