Skip to content

Comments

variants refactor#141

Merged
korgon merged 42 commits intodevelopfrom
variants_refactor
Jan 16, 2026
Merged

variants refactor#141
korgon merged 42 commits intodevelopfrom
variants_refactor

Conversation

@chrisFrazier77
Copy link

can use athos api built in variants,
badges in variants,
variantSelectors in result component,
display disabled selections

…n variants,variantSelectors in result component,display disabled selections
Copilot AI review requested due to automatic review settings November 12, 2025 17:38
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors variant handling to use the Athos API's built-in variant support, adding several enhancements including badge management for variants, variant selectors in result components, and the ability to display disabled variant selections.

Key changes:

  • Adds support for Athos API built-in variants structure with direct integration
  • Implements variant-specific badge handling that updates when variants are selected
  • Adds hideVariantSelections prop to Result component for controlling variant selector visibility
  • Introduces showDisabledSelections config option to display unavailable variant options

Reviewed Changes

Copilot reviewed 14 out of 15 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
packages/snap-store-mobx/src/types.ts Makes field optional and adds showDisabledSelections config to support Athos API variants
packages/snap-store-mobx/src/Search/Stores/SearchResultStore.ts Implements variant badge support, removes field requirement checks, and adds disabled selection tracking
packages/snap-store-mobx/src/Search/Stores/SearchResultStore.test.ts Adds comprehensive test coverage for Athos API variants and badge behavior
packages/snap-shared/src/MockData/meta/atkzs2/meta.json New mock metadata file for Athos API variant testing
packages/snap-preact/components/tests/cypress/component/molecules/result.cy.tsx New E2E tests for Result component with variant selections
packages/snap-preact/components/src/components/Molecules/VariantSelection/VariantSelection.tsx Styling updates for variant selection dropdowns including disabled states
packages/snap-preact/components/src/components/Molecules/Result/readme.md Documents new hideVariantSelections prop
packages/snap-preact/components/src/components/Molecules/Result/Result.tsx Adds variant selection rendering and fixes rating wrapper class name
packages/snap-preact/components/src/components/Molecules/Result/Result.test.tsx Test file moved to skip file
packages/snap-preact/components/src/components/Molecules/Result/Result.stories.tsx Adds Storybook controls for hideVariantSelections
packages/snap-preact/components/src/components/Molecules/Result/Result-test.skip Contains skipped tests from Result.test.tsx
packages/snap-preact/components/src/components/Molecules/OverlayBadge/OverlayBadge.tsx Updates to use display.badges for variant badge support
packages/snap-preact/components/src/components/Molecules/CalloutBadge/CalloutBadge.tsx Updates to use display.badges for variant badge support
packages/snap-client/src/Client/transforms/searchResponse.ts Transforms Athos variant data structure and adds badge support to variants

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

This was linked to issues Nov 12, 2025
@chrisFrazier77 chrisFrazier77 linked an issue Dec 3, 2025 that may be closed by this pull request
Copy link

@korgon korgon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple small adjustments.

Copy link

@korgon korgon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's do the following changes:

  • pagination - lets make it look like carousel pagination (but still use Button component) - no icons, but need name
  • need to spread variantSelection sub props in sub-component of Result component
  • centerInsufficientSlides (or better named) prop
  • alwaysShowNavigation prop to ensure consistent display (when desired - off by default)
  • alt -> slideImageAlt

@chrisFrazier77 chrisFrazier77 requested a review from korgon January 13, 2026 20:07
Copy link

@korgon korgon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good.

@chrisFrazier77 chrisFrazier77 requested a review from korgon January 13, 2026 21:20
Copy link

@korgon korgon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Big PR... Looks good.

@korgon korgon merged commit f50da5e into develop Jan 16, 2026
1 check passed
@korgon korgon deleted the variants_refactor branch January 16, 2026 02:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

lightweight carousel component Track Variant Parent Id Variant Badge Support Transform API Response

2 participants