-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
supports wasm fetch credentials #1227
Conversation
d92087f
to
e9ec241
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
Would it be possible to do similar to the other wasm-specific methods that we've added before. I think there's some around CORS mode. Specifically, don't expose the RequestCredentials
type, since that would prevent us from ever changing to a different internal dependency or version of it.
Do you mean we provide three methods like fetch_credentials_same_origin, fetch_credentials_omit, fetch_credentials_ include? And I will delete the RequestCredentials export. |
27a0be1
to
adb5cc5
Compare
9eb19cd
to
fd5ab44
Compare
The cargo check has been failed, seems we need to upgrade rust toolchain to 1.46.0 or later to solve that. |
d21369d
to
0d251a9
Compare
Sorry for my PUSH-FORCE which makes the CI info disappear , I just want to keep the commit clean. We can reproduce the cargo check failure with rust 1.45.2 and the latest master branch of this repo. The reason is that socket2 of this crate's dependency was been upgraded to 0.4.0, which can't compile on rust 1.45.2, related issue is here |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the updates (apologies, I was away for a week, catching up again). I'll restart CI and this should be good to go.
Support set fetch credentials in wasm.