Test and fix a regression in parsing partial requests in the 1.9.x series #176
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A regression was introduced in this bit of the SWAR changeset which manifests as incorrectly classifying a
read()
with the contentsGET
as a token error (because there's no characters yet to parse for the path part) rather than as anOk(Status::Partial)
.This diff is three independent commits to:
parse_uri()
function to disambiguate between an empty path followed by a space, versus a partial read that ends at the start of the path.NB. This'll conflict with #175 — not in a material way, they'll work fine together, just a note.