Skip to content

Commit

Permalink
pr num before matrix feature
Browse files Browse the repository at this point in the history
  • Loading branch information
AaronO committed Sep 1, 2024
1 parent 9c94628 commit ff3dd7b
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions .github/workflows/cibench.yml
Original file line number Diff line number Diff line change
Expand Up @@ -72,14 +72,14 @@ jobs:
- name: Run benchmarks (PR)
run: |
git checkout ${{ github.event.pull_request.head.sha }}
cargo bench --bench parse -- --save-baseline pr-${{ matrix.feature }}-${{ github.event.pull_request.number }}
cargo bench --bench parse -- --save-baseline pr-${{ github.event.pull_request.number }}-${{ matrix.feature }}
env:
CARGO_CFG_HTTPARSE_DISABLE_SIMD: ${{ matrix.feature == 'swar' && '1' || '0' }}
RUSTFLAGS: ${{ matrix.feature != 'swar' && format('-C target-feature=+{0}', matrix.feature) || '' }}

- name: Compare benchmarks
run: |
critcmp -t 5 master-${{ matrix.feature }} pr-${{ matrix.feature }}-${{ github.event.pull_request.number }}
critcmp -t 5 master-${{ matrix.feature }} pr-${{ github.event.pull_request.number }}-${{ matrix.feature }}
benchmark-aarch64:
name: Run aarch64 benchmarks
Expand Down Expand Up @@ -113,11 +113,11 @@ jobs:
- name: Run benchmarks (PR)
run: |
git checkout ${{ github.event.pull_request.head.sha }}
cargo bench --bench parse -- --save-baseline pr-aarch64-${{ matrix.feature }}-${{ github.event.pull_request.number }}
cargo bench --bench parse -- --save-baseline pr-${{ github.event.pull_request.number }}-aarch64-${{ matrix.feature }}
env:
CARGO_CFG_HTTPARSE_DISABLE_SIMD: ${{ matrix.feature == 'swar' && '1' || '0' }}
RUSTFLAGS: ${{ matrix.feature == 'neon' && '-C target-feature=+neon' || '' }}

- name: Compare benchmarks
run: |
critcmp -t 5 master-aarch64-${{ matrix.feature }} pr-aarch64-${{ matrix.feature }}-${{ github.event.pull_request.number }}
critcmp -t 5 master-aarch64-${{ matrix.feature }} pr-${{ github.event.pull_request.number }}-aarch64-${{ matrix.feature }}

0 comments on commit ff3dd7b

Please sign in to comment.