Export the Path variable rather than appending to it
#12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `addPath` will invert the path ordering as each entry is appended to the environment file, which is then reversed and prepended to the environment at the end of the action. This results in the additions being in reverse order. However, since we know that `vsdevcmd` will adjust the path on both ends, simply prefer to use the `exportVariable` rather than try to be clever to adjust the path via `addPath`. Fixes: seanmiddleditch#10.
seanmiddleditch
approved these changes
Oct 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
addPathwill invert the path ordering as each entry is appended to theenvironment file, which is then reversed and prepended to the environment at the
end of the action. This results in the additions being in reverse order.
However, since we know that
vsdevcmdwill adjust the path on both ends, simplyprefer to use the
exportVariablerather than try to be clever to adjust thepath via
addPath.Fixes: #10.