Add settings xml validation including an unescaped character check #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (3)
.github/workflows/buildsolution.yml:34
- The path parameter uses double backslashes which might be incorrect. Verify if single backslashes should be used instead.
path: '\mspfedyn_\OrgDbOrgSettings\Solution\WebResources\mspfedyn_\OrgDbOrgSettings\'
.github/workflows/buildsolution.yml:45
- [nitpick] The error message could be more specific by including details from the exception.
Write-Host "Error: XML is not well-formed."
.github/workflows/buildsolution.yml:38
- The newly added XML validation and unescaped character check should be covered by tests to ensure it works as expected.
run: |
seanmcne
added a commit
that referenced
this pull request
Jan 22, 2025
) (#136) * adding settings xml validation
seanmcne
added a commit
that referenced
this pull request
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.