Skip to content

Commit

Permalink
regression: org.slf4j used instead of internal logging abstraction
Browse files Browse the repository at this point in the history
In 3.36.0 we created a runtime dependency on org.slf4j that was not there before. We now use our own logging abstraction instead.

We intend to switch wholesale to slf4j in 4.x but we shouldn't be adding new dependencies without bumping the major version number.
  • Loading branch information
seanbright committed Aug 28, 2024
1 parent 3f43be3 commit 48bf00b
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 8 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -19,12 +19,11 @@
import org.asteriskjava.manager.response.ManagerError;
import org.asteriskjava.manager.response.ManagerResponse;
import org.asteriskjava.manager.util.EventAttributesHelper;
import org.slf4j.Logger;
import org.asteriskjava.util.Log;
import org.asteriskjava.util.LogFactory;

import java.util.*;

import static org.slf4j.LoggerFactory.getLogger;

/**
* Default implementation of the ResponseBuilder interface.
*
Expand All @@ -33,7 +32,7 @@
* @see org.asteriskjava.manager.response.ManagerResponse
*/
class ResponseBuilderImpl implements ResponseBuilder {
private static final Logger logger = getLogger(ResponseBuilderImpl.class);
private static final Log logger = LogFactory.getLog(ResponseBuilderImpl.class);

private static final Set<String> ignoredAttributes = new HashSet<>(Arrays.asList(
"attributes", "proxyresponse", ManagerReader.COMMAND_RESULT_RESPONSE_KEY));
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,9 @@
import org.asteriskjava.manager.event.UserEvent;
import org.asteriskjava.manager.response.ManagerResponse;
import org.asteriskjava.util.AstUtil;
import org.asteriskjava.util.Log;
import org.asteriskjava.util.LogFactory;
import org.asteriskjava.util.ReflectionUtil;
import org.slf4j.Logger;

import java.lang.reflect.Constructor;
import java.lang.reflect.Method;
Expand All @@ -29,13 +30,11 @@
import java.util.Map;
import java.util.Set;

import static org.slf4j.LoggerFactory.getLogger;

/**
* @author Piotr Olaszewski <piotrooo>
*/
public class EventAttributesHelper {
private static final Logger logger = getLogger(EventAttributesHelper.class);
private static final Log logger = LogFactory.getLog(EventAttributesHelper.class);

private EventAttributesHelper() {
}
Expand Down

0 comments on commit 48bf00b

Please sign in to comment.