Compare distribution of differences in InterRowMSAS instead of average #805
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #805 +/- ##
==========================================
- Coverage 95.74% 95.74% -0.01%
==========================================
Files 117 117
Lines 4748 4746 -2
==========================================
- Hits 4546 4544 -2
Misses 202 202
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
sarahmish
force-pushed
the
issue-800-compare-distribution-not-average
branch
from
272ed6d to
b0dc97c
Compare
gsheni
reviewed
Oct 24, 2025
| return np.nan | ||
| group = group.to_numpy() | ||
| with warnings.catch_warnings(): | ||
| warnings.filterwarnings('ignore', message='Mean of empty slice') |
There was a problem hiding this comment.
Do we need to check the warning does not show in the test?
There was a problem hiding this comment.
After removing np.mean function, there shouldn't be a way to trigger "Mean of empty slice" warning.
gsheni
approved these changes
Oct 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #800.
CU-86b75h34x