Skip to content

chore/TestCode #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dayeondev merged 5 commits into from
Dec 3, 2024
Merged

chore/TestCode #55

dayeondev merged 5 commits into from
Dec 3, 2024

Conversation

@dayeondev
Copy link
Collaborator

@dayeondev dayeondev commented Nov 28, 2024

변경된 점

  • 일부 entity 코드에 테스트코드를 추가하였습니다.

비고

  • 게임 로직 부분이 DI로 작성되지 않은 종속성이 매우 높은 상황입니다. 따라서 종속성이 적은 entity 패키지, 그 중 테스트 시 의미가 있다고 판단되는 클래스에 대해 선별적으로 작성하였습니다.

CSE2024SDP-196

@dayeondev
Chore/linter (#53)
2afe525 
lint도구 추가

CSE2024SDP-197
@dayeondev
test: 테스트코드 추가
9c74098 
BulletPool의 경우, Pool을 이용한 테스트가 가능하도록 메서드를 추가하였습니다.

CSE2024SDP-235
@dayeondev dayeondev self-assigned this Nov 28, 2024
@dayeondev
Copy link
Collaborator Author

dayeondev commented Nov 28, 2024

✅ 테스트 성공

  • 총 테스트: 18개
  • 성공: 18개
  • 실패: 0개
  • 에러: 0개
  • 스킵됨: 0개

모든 테스트를 성공적으로 통과했습니다! 🎉

lee-si-yeon
lee-si-yeon approved these changes Nov 29, 2024
View reviewed changes
Copy link
Member

@lee-si-yeon lee-si-yeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

정상적으로 테스트 작동되는 것 확인했습니다:)

@dayeondev
Copy link
Collaborator Author

dayeondev commented Dec 3, 2024

❌ 테스트 결과 디렉터리가 존재하지 않습니다.

@dayeondev
Copy link
Collaborator Author

dayeondev commented Dec 3, 2024

❌ 테스트 결과 디렉터리가 존재하지 않습니다.

@dayeondev
Copy link
Collaborator Author

dayeondev commented Dec 3, 2024

attackDamage 추가로 인해 테스트코드 돌지 못함. 수정 필요함.

@dayeondev
Copy link
Collaborator Author

dayeondev commented Dec 3, 2024

❌ 테스트 결과 디렉터리가 존재하지 않습니다.

@dayeondev
Copy link
Collaborator Author

dayeondev commented Dec 3, 2024

✅ 테스트 성공

  • 총 테스트: 18개
  • 성공: 18개
  • 실패: 0개
  • 에러: 0개
  • 스킵됨: 0개

모든 테스트를 성공적으로 통과했습니다! 🎉

@dayeondev dayeondev merged commit 000cf83 into develop Dec 3, 2024
1 check passed
@dayeondev dayeondev deleted the chore/TestCode branch December 3, 2024 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lee-si-yeon lee-si-yeon lee-si-yeon approved these changes

Assignees

@dayeondev dayeondev

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dayeondev @lee-si-yeon