Skip to content

feat: test workflow 추가 #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dayeondev merged 4 commits into from
Nov 27, 2024
Merged

feat: test workflow 추가 #47

dayeondev merged 4 commits into from
Nov 27, 2024

Conversation

@dayeondev
Copy link
Collaborator

@dayeondev dayeondev commented Nov 26, 2024 •
edited
Loading

변경 사항

master, develop브랜치에 머지 시, 테스트 코드를 동작시키도록 하였습니다.
테스트에 실패하면 merge가 저지됩니다.

비고

  • 하단의 두 코멘트를 봐주시면 좋을 것 같아요. 첫 코멘트는 fail입니다. (일부러 잘못된 테스트 케이스를 넣었습니다.) 그리고 실패한 케이스를 수정하여 마지막 코멘트에서는 성공을 보입니다.
  • 이전처럼 코드 실행으로 확인 가능한 사항이 아닙니다. 적용 이후 PR부터 검증될 테이니, 약간의 검토정도만 하고 승인 주시는 것도 방법일 것 같습니다.
  • 리포트 보는 방법도 기재해두었으니 참조하시면 도움이 될 것 같습니다. CI-Test 관련

CSE2024SDP-195

@dayeondev dayeondev self-assigned this Nov 26, 2024
@dayeondev
Copy link
Collaborator Author

dayeondev commented Nov 26, 2024 •
edited
Loading

tmp

@dayeondev dayeondev closed this Nov 26, 2024
@dayeondev dayeondev reopened this Nov 26, 2024
@dayeondev dayeondev force-pushed the chore/CI branch 11 times, most recently from 3cbee00 to 69b2837 Compare November 26, 2024 12:05
@dayeondev
Copy link
Collaborator Author

dayeondev commented Nov 26, 2024 •
edited
Loading

tmp

@dayeondev dayeondev force-pushed the chore/CI branch 3 times, most recently from 98fba8a to bb448d7 Compare November 26, 2024 12:23
@dayeondev
Copy link
Collaborator Author

dayeondev commented Nov 26, 2024 •
edited
Loading

tmp

1 similar comment
@dayeondev
Copy link
Collaborator Author

dayeondev commented Nov 26, 2024 •
edited
Loading

tmp

@dayeondev
Copy link
Collaborator Author

dayeondev commented Nov 26, 2024 •
edited
Loading

tmp

@dayeondev
Copy link
Collaborator Author

dayeondev commented Nov 26, 2024 •
edited
Loading

tmp

@dayeondev
Copy link
Collaborator Author

dayeondev commented Nov 26, 2024 •
edited
Loading

tmp

@dayeondev
Copy link
Collaborator Author

dayeondev commented Nov 26, 2024 •
edited
Loading

tmp

@dayeondev
Copy link
Collaborator Author

dayeondev commented Nov 26, 2024

❌ 테스트 실패

  • 총 테스트: 6개
  • 성공: 5개
  • 실패: 1개
  • 에러: 0개
  • 스킵됨: 0개

실패한 테스트 상세 내역:

번호 테스트 클래스 테스트 메서드 에러 메시지
1 example.HelloWorldTest testHelloWorldMessageFail() org.opentest4j.AssertionFailedError: The message should be 'Hello, World!' ==> expected: <Hello, Wor...

자세한 내용은 테스트 리포트를 확인해주세요.

@dayeondev
Copy link
Collaborator Author

dayeondev commented Nov 26, 2024

✅ 테스트 성공

  • 총 테스트: 5개
  • 성공: 5개
  • 실패: 0개
  • 에러: 0개
  • 스킵됨: 0개

모든 테스트를 성공적으로 통과했습니다! 🎉

PIut0
PIut0 approved these changes Nov 26, 2024
View reviewed changes
Copy link

@PIut0 PIut0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

테스팅 코드는 python 으로 구현되어있네요.
고생많으셨습니다!

@dayeondev
chore: workflow의 error 통과 요청 건 외1
16e3187 
* 에러 발생하여도 merge에 문제 없도록 함.
* 불필요한 주석 제거

CSE2024SDP-221
@dayeondev
Copy link
Collaborator Author

dayeondev commented Nov 27, 2024

✅ 테스트 성공

  • 총 테스트: 5개
  • 성공: 5개
  • 실패: 0개
  • 에러: 0개
  • 스킵됨: 0개

모든 테스트를 성공적으로 통과했습니다! 🎉

@dayeondev
Copy link
Collaborator Author

dayeondev commented Nov 27, 2024

✅ 테스트 성공

  • 총 테스트: 5개
  • 성공: 5개
  • 실패: 0개
  • 에러: 0개
  • 스킵됨: 0개

모든 테스트를 성공적으로 통과했습니다! 🎉

@dayeondev dayeondev merged commit 3b4a458 into develop Nov 27, 2024
1 check passed
@dayeondev dayeondev deleted the chore/CI branch November 27, 2024 08:58
dayeondev added a commit that referenced this pull request Nov 28, 2024
@dayeondev @github-actions
feat: test workflow 추가 (#47)
27de9a9 
* develop/masterfeat: test workflow 추가
* 테스트에 에러 발생하여도 merge에 문제 없도록 변경

CSE2024SDP-195
dayeondev added a commit that referenced this pull request Nov 28, 2024
@dayeondev @github-actions
feat: test workflow 추가 (#47)
01a579f 
* develop/masterfeat: test workflow 추가
* 테스트에 에러 발생하여도 merge에 문제 없도록 변경

CSE2024SDP-195
@dayeondev dayeondev added the enhancement New feature or request label Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PIut0 PIut0 PIut0 approved these changes

Assignees

@dayeondev dayeondev

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dayeondev @PIut0