-
Notifications
You must be signed in to change notification settings - Fork 133
Add JDK Mission Control 9.1.1-zulu #742
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
marc0der
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm curious why this PR is only adding Zulu, and not any of the other vendors. It feels incomplete if we favour only a single vendor.
|
Thanks for the feedback, you’re absolutely right. I’ve gone ahead and added entries for the other vendors* as well. Note that since Zulu is currently specified as the JMC default version, I selected Please take a look when you get a chance! * Amazon and Bellsoft appear to have suspended distribution of JMC for several years, but I believe adding these latest versions is worthwhile. |
marc0der
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thank you!
|
A CI error occurred. https://github.com/sdkman/sdkman-db-migrations/actions/runs/19242132885/job/55126926030 Looks like the CI environment is using an outdated Java version, which no longer has valid CA certificates. I was able to reproduce the same error locally with Java 11.0.11 - the same version used in CI. I've updated the CI setup to use the latest Java 11.x to see if that resolves the issue. The same update worked fine on my local environment. |
|
@sciencesakura apologies, I only saw this now! Feel free to remove any migrations that are causing the build to break as part of your PR. |
No description provided.