Skip to content

Allow direct construction of LogicalPlan nodes #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sadboy merged 1 commit into from
Oct 28, 2025
Merged

Allow direct construction of LogicalPlan nodes #103

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 1 addition & 8 deletions datafusion/expr/src/logical_plan/plan.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2121,8 +2121,6 @@ impl PartialOrd for Values {
/// Evaluates an arbitrary list of expressions (essentially a
/// SELECT with an expression list) on its input.
#[derive(Clone, PartialEq, Eq, Hash, Debug)]
// mark non_exhaustive to encourage use of try_new/new()
#[non_exhaustive]
pub struct Projection {
/// The list of expressions
pub expr: Vec<Expr>,
Expand Down Expand Up @@ -2206,8 +2204,6 @@ pub fn projection_schema(input: &LogicalPlan, exprs: &[Expr]) -> Result<Arc<DFSc

/// Aliased subquery
#[derive(Debug, Clone, PartialEq, Eq, Hash)]
// mark non_exhaustive to encourage use of try_new/new()
#[non_exhaustive]
pub struct SubqueryAlias {
/// The incoming logical plan
pub input: Arc<LogicalPlan>,
Expand Down Expand Up @@ -2296,7 +2292,6 @@ impl PartialOrd for SubqueryAlias {
/// Filter should not be created directly but instead use `try_new()`
/// and that these fields are only pub to support pattern matching
#[derive(Debug, Clone, PartialEq, Eq, PartialOrd, Hash)]
#[non_exhaustive]
pub struct Filter {
/// The predicate expression, which must have Boolean type.
pub predicate: Expr,
Expand Down Expand Up @@ -2595,7 +2590,7 @@ impl Debug for TableScan {
.field("projected_schema", &self.projected_schema)
.field("filters", &self.filters)
.field("fetch", &self.fetch)
.finish_non_exhaustive()
.finish()
}
}

Expand Down Expand Up @@ -3509,8 +3504,6 @@ impl PartialOrd for DistinctOn {
/// "C+B" and "SUM(A)" are the names of the output columns. Note that "C+B" is a
/// single new column
#[derive(Debug, Clone, PartialEq, Eq, Hash)]
// mark non_exhaustive to encourage use of try_new/new()
#[non_exhaustive]
pub struct Aggregate {
/// The incoming logical plan
pub input: Arc<LogicalPlan>,
Expand Down
Loading