Update to DataFusion 48.0.1 #100
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing ORDER BY clause (apache#16257) * Add order by clause to limit query for consistent results * test: update explain plan (cherry picked from commit 4cf1148)
Unclear why it doesn't work.
* Fix WindowFrame::new with order_by Before the change, the frame constructed with `WindowFrame::new(Some(true))` would not be fully functional, because of the bound being of unexpected type. * Change assert helper param order Putting expected data second allows for natural inlining of expected values. (cherry picked from commit 20a723b)
Update `find_window_exprs` signature to be as flexible as `find_aggregate_exprs`, letting the caller avoid Expr clones. (cherry picked from commit 4a4ffd7)
…#97) * cherry pick the array agg fix to support multiple sorted aggregations * Test fix * Fix some goldies * Fix some more goldies * Fix some more goldies
findepi
force-pushed
the
findepi/sdf/48
branch
from
b7769bc to
667beae
Compare
findepi
force-pushed
the
findepi/sdf/48
branch
from
e01b487 to
667beae
Compare
* Implement equals for stateful functions Default implementation of `ScalarUDFImpl::equals`, `AggregateUDFImpl::equals` and `WindowUDFImpl::equals` is correct for stateless functions and those which only state is the `Signature`, which is most of the functions. This implements `equals` and `hash_value` for functions that have state other than `Signature` object. This fixes correctness issues which could occur when such stateful functions are used together in one query. * downgrade for MSRV * Improve doc * Update default UDF:: equals to compare aliases too * Update default UDF:: equals to compare type too (‼️ ) * remove now-obsoleted UDF equals/hash customizations remove these which compare signature, aliases, as the default handles these now * remove equals impl which compares name, signature -- default does that * cleanup imports (cherry picked from commit afd8235)
findepi
force-pushed
the
findepi/sdf/48
branch
from
667beae to
c06664e
Compare
Extract AggregateUDFImpl method that have complex implementations. This makes it feasible to implement that trait with `#[warn(clippy::missing_trait_methods)]` Clippy check enabled. That check is very helpful when the type implementing `AggregateUDFImpl` delegates many methods to another `AggregateUDFImpl` implementation and therefore does not want to unconsciously rely on default implementation. Sadly, Rust does not allow explicitly delegating to trait method's default implementation. Extracting the logic to standalone functions works around that limitation.
findepi
force-pushed
the
findepi/sdf/48
branch
from
7daa81e to
c9a52cc
Compare
vgapeyev
approved these changes
Sep 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.