Skip to content

Disable dynamic stack growth #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
felipecrv wants to merge 1 commit into from
Closed

Disable dynamic stack growth #83

felipecrv wants to merge 1 commit into from

Conversation

@felipecrv
Copy link
Collaborator

@felipecrv felipecrv commented Apr 2, 2025

No description provided.

@github-actions github-actions bot added the core label Apr 2, 2025
@felipecrv felipecrv force-pushed the felipe/disable-stack-growth branch from 7bb54f2 to 25a8680 Compare April 2, 2025 16:57
@felipecrv felipecrv requested a review from findepi April 2, 2025 16:59
@felipecrv
Copy link
Collaborator Author

felipecrv commented Apr 2, 2025

Tests fail...

thread 'tpcds_logical_q64' has overflowed its stack
fatal runtime error: stack overflow
error: test failed, to rerun pass `-p datafusion --test tpcds_planning`

@felipecrv felipecrv force-pushed the felipe/disable-stack-growth branch from 25a8680 to 9971249 Compare April 2, 2025 17:50
findepi
findepi reviewed Apr 2, 2025
View reviewed changes
datafusion-cli/Cargo.toml
"parquet",
"recursive_protection",
# See comment about recursive_protection in datafusion/core/Cargo.toml
# "recursive_protection",
Copy link

@findepi findepi Apr 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's not change necessary. we can disable in internal repo only

Copy link

@findepi findepi Apr 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(DM)

@felipecrv felipecrv closed this Apr 2, 2025
findepi pushed a commit that referenced this pull request Aug 13, 2025
@phillipleblanc
Improve unproject_sort_expr to handle arbitrary expressions (apache…
16c7939 
…#16127)

* Add failing test to demonstrate problem

* Improve `unproject_sort_expr` to handle arbitrary expressions (#83)

* Remove redundant return
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChenyuLInx ChenyuLInx ChenyuLInx approved these changes

+1 more reviewer

@findepi findepi findepi left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

core

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@felipecrv @findepi @ChenyuLInx