Skip to content

Commit 25a8680

Browse files
committed
Disable dynamic stack growth
1 parent fba7174 commit 25a8680

File tree

2 files changed

+9
-2
lines changed

2 files changed

+9
-2
lines changed

datafusion-cli/Cargo.toml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,8 @@ datafusion = { path = "../datafusion/core", version = "45.0.0", features = [
4343
"datetime_expressions",
4444
"encoding_expressions",
4545
"parquet",
46-
"recursive_protection",
46+
# See comment about recursive_protection in datafusion/core/Cargo.toml
47+
# "recursive_protection",
4748
"regex_expressions",
4849
"unicode_expressions",
4950
"compression",

datafusion/core/Cargo.toml

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,13 @@ default = [
5656
"unicode_expressions",
5757
"compression",
5858
"parquet",
59-
"recursive_protection",
59+
# The recursive_protection depends on recursive which depends on stacker.
60+
# Stacker makes dynamical stack size modification calls that are not allowed
61+
# by default in a Kubernetes environment [1]. So we decided to disable this
62+
# feature and any stack overflow problem in prod will be dealt with by us
63+
# change the ulimit settings manually.
64+
# [1] https://dbt-labs.slack.com/archives/C089D42USM7/p1743532071628859
65+
# "recursive_protection",
6066
]
6167
encoding_expressions = ["datafusion-functions/encoding_expressions"]
6268
# Used for testing ONLY: causes all values to hash to the same value (test for collisions)

0 commit comments

Comments
 (0)