Implement AsRef for Schema and Field #15
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
findepi
commented
Sep 23, 2025
findepi
commented
- clones Implement AsRef for Schema and Field apache/arrow-rs#8417
This allows writing generic code that accepts `&Field`, `Arc<Field>` or `&Arc<Field>`, or iterators of these. Same for `Schema`.
vgapeyev
approved these changes
Sep 24, 2025
vgapeyev
left a comment
vgapeyev
left a comment
There was a problem hiding this comment.
For maybe some context, is this a forward patch from an upcoming Arrow, or is there a reason not to try upstreaming?
Author
the upstream PR is linked in the description it's approved, but not merged |
fa-assistant
pushed a commit
to dbt-labs/dbt-fusion
that referenced
this pull request
Sep 25, 2025
Update post sdf-labs/arrow-rs#15 merge. The arrow dep was earlier updated to a pre-merge PR to unblock SQL compiler bug fix. GitOrigin-RevId: 7fb289ed8b095eaabbe47bd3a080ba2d1280ebe2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.