Enabling symbolic execution support for filters, joins and unions #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Exposing arrow datatype to z3 type converter in mod
The module defines methods to construct primitive array from indexes of the input primitive array. We need to make sure that the symbolic data of the input primitive array is copied into the constructed primitive array
gliga
reviewed
Jun 12, 2025
| } | ||
|
|
||
| fn to_symbolic_data(&self) -> super::SymbolicArrayData { | ||
| dbg!(&self.data_type, &self, &self.symbolic_data); |
There was a problem hiding this comment.
how did we end up with dbg lines in the first place? For other repos we have a protection, should we lint here as well?
gliga
reviewed
Jun 12, 2025
| Boolean, | ||
| /// A string variable | ||
| String, | ||
| /// A int variable |
gliga
reviewed
Jun 12, 2025
| DataType::Int8 | DataType::Int16 | DataType::Int32 | DataType::Int64 | | ||
| DataType::UInt8 | DataType::UInt16 | DataType::UInt32 | DataType::UInt64 | | ||
| DataType::Decimal128(_, _) | DataType::Decimal256(_, _) => VarType::Int, | ||
| _ => VarType::String, // Default to String for other types |
There was a problem hiding this comment.
what are those other types and why is string ok? Is it safer to return an error in this case
gliga
reviewed
Jun 12, 2025
| r.clone(), | ||
| )); | ||
| for j in 0..syms2.len() { | ||
| let l = &syms1[i]; |
There was a problem hiding this comment.
why is this not outside the nested loop?
gliga
reviewed
Jun 12, 2025
| } else { | ||
| vec![] | ||
| }; | ||
| all_constraints.extend(constraints.unwrap_or_default()); |
There was a problem hiding this comment.
potentially move into the branches above to avoid mut
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request merges the latest four commits on
aditya/sym_evalintomichael/sym-eval.takesym!macro to pair every element of the two batches (quadratic join)VarTypeenum andarrow_type_to_var_typefor correct Z3 typing. Add row offset field to symbolic variable to support unionsdbg!calls across array / select modules