Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added frequency sliders for the tone stack #434

Closed
wants to merge 1 commit into from

Conversation

fichl
Copy link
Contributor

@fichl fichl commented Feb 5, 2024

sliders to control the frequency of the individual tone stack knobs.
show / hide with the new icon next to the EQ-text
double click on sliders restore original default values

Screenshot_249

Screenshot_250

Screenshot_251

@sdatkinson
Copy link
Owner

sdatkinson commented Mar 10, 2024

Thanks for the PR.

I don't think I'm going to merge this because I don't like the assumption that there's "a" frequency associated with each knob. For example, currently, the mids' Q adapts based on whether the knob is cutting or boosting, and general "tone stack" EQs can be modeled by altering the structure of the EQ filters as the knobs move (see e.g. TSC).

So by introducing more controls, that makes these assumptions about how it operates become constraints, and I don't want to box in this plugin like that--better for others to extend it and make those choices, while this gives them the option to do so.

FWIW, it'd be neat to refactor the tone stack code to be a little tidier in ProcessBlock--perhaps that would make it easier to be able to roll this customization on top of this repo. I've sketched an Issue for this: #441

Then you'd be able to subclass the tone stack as you'd like, set up the parameter stuff accordingly, and that should make it relatively easy to maintain this customization.

@sdatkinson sdatkinson closed this Mar 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants