Update to the latest iPlug2 with RealtimeResampler #406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olilarkin
force-pushed
the
update-iplug2-resampling
branch
from
d503342 to
853b7c3
Compare
This may be the root cause of #407. |
|
Thanks! I've incorporated this into #408 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should switch to the (rebased) utf8-fixes branch, which includes the fixed RealtimeResampler class. It renames the resampler class and update the file browser control due to a changed member variable and prevent a crash when folders with subfolders are added. Changes to the RealtimeResampler class also include fixes todo with the buffer memory being zeroed and the buffer always being fixed at DEFAULT_BLOCK_SIZE instead of set dynamically.