Computational Art Submission #8
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SeunginLyu
reviewed
Oct 12, 2017
SeunginLyu
left a comment
SeunginLyu
left a comment
There was a problem hiding this comment.
Looks good overall! I would definitely suggest you add more documentation in your future projects.
| """ | ||
| # TODO: implement this | ||
| pass | ||
| if len(f)==1: |
There was a problem hiding this comment.
I recommend that you add one or two unit tests of your own to test the function.
| return ['x'] | ||
| return ['y'] | ||
| choice = random.randint(0, len(function) - 1) | ||
| if(choice > 4): |
There was a problem hiding this comment.
it would be easier to understand the code if you put an inline comment explaining why you made this choice.
| generate_art("example2.png") | ||
|
|
||
| # Test that PIL is installed correctly | ||
| # # Test that PIL is installed correctly |
There was a problem hiding this comment.
please remove these comments for you final code submission
| import doctest | ||
| doctest.testmod() | ||
| # if __name__ == '__main__': | ||
| # import doctest |
There was a problem hiding this comment.
please remove these comments for you final code submission
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.