Pull request #14
Open
Pull request #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SeunginLyu
reviewed
Oct 8, 2017
SeunginLyu
left a comment
SeunginLyu
left a comment
There was a problem hiding this comment.
Looks good. A few lines of inline comments wouldn't hurt though!
|
|
||
| building_blocks = ['x','y','cos_pi','sin_pi','prod','avg','tan_pi','substract',] | ||
| pick = random.choice(building_blocks) | ||
| i = random.randint(min_depth, max_depth) |
There was a problem hiding this comment.
something like random_depth would be a more appropriate variable name. i does not give you any semantic information about the variable.
There was a problem hiding this comment.
but I don't see you using it anywhere else in the code.
| if __name__ == '__main__': | ||
| import doctest | ||
| doctest.testmod() | ||
| #doctest.testmod(verbose = True) |
There was a problem hiding this comment.
please remove comments for your final submission
| # TODO: implement this | ||
| pass | ||
|
|
||
| output_val = input_interval_end - input_interval_start |
There was a problem hiding this comment.
it would be useful to add more unit tests for this function, just to confirm that it works for all ranges.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.