Wrap stream.Read for safety consideration
#153
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkropachev
force-pushed
the
dk/replace-unsafe-stream-read
branch
from
41171fb to
a952ebf
Compare
dkropachev
force-pushed
the
dk/replace-unsafe-stream-read
branch
from
6b86683 to
e305d3d
Compare
wprzytula
reviewed
Oct 16, 2025
dkropachev
force-pushed
the
dk/replace-unsafe-stream-read
branch
from
e305d3d to
a6279b7
Compare
dkropachev
force-pushed
the
dk/replace-unsafe-stream-read
branch
from
a6279b7 to
10c37d7
Compare
`FrameReader` and `FrameWriter` has code that reads from the Stream. This code uses `Stream.Read` which does not guarantee that requested number of bytes are read and it does not check how much bytes it read. Simple solution would to be replace it with `Stream.ReadExactly`, but it is not supported in net6. So, only choice here is implement a code that blocks until requested bytes are read.
Test is designed for protocol v5, but uses GetResponse with default V4, which endsup in error.
dkropachev
force-pushed
the
dk/replace-unsafe-stream-read
branch
from
10c37d7 to
ef317d7
Compare
wprzytula
approved these changes
Oct 16, 2025
sylwiaszunejko
approved these changes
Oct 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FrameReaderandFrameWriterhas code that reads from the Stream. This code usesStream.Readwhich does not guarantee that requested number of bytes are read and it does not check how much bytes it read.Simple solution would to be replace it with
Stream.ReadExactly, but it is not supported in net6.So, only choice here is implement a code that blocks until requested bytes are read.