Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve CellLine metadata module UX #717

Merged
merged 2 commits into from
Feb 26, 2025

Conversation

JiriBruthans
Copy link
Contributor

PR Checklist

  • Referenced issue is linked
  • Documentation in docs is updated

Description of changes

Updated documentation for CellLine.annotate_bulk_rna and CellLine.annotate.
Improved handeling of default parameters for CellLine.annotate_bulk_rna.
Replaced warning with error in CellLine.correlate if genes don't match.
Updated CellLine.annotate_protein_expression for example in documentation to work.

Additional context

Fixes #664

@codecov-commenter
Copy link

codecov-commenter commented Feb 24, 2025

Codecov Report

Attention: Patch coverage is 33.33333% with 8 lines in your changes missing coverage. Please review.

Project coverage is 65.77%. Comparing base (7b9d965) to head (18da81d).

Files with missing lines Patch % Lines
pertpy/metadata/_cell_line.py 33.33% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #717      +/-   ##
==========================================
- Coverage   65.79%   65.77%   -0.03%     
==========================================
  Files          47       47              
  Lines        6137     6144       +7     
==========================================
+ Hits         4038     4041       +3     
- Misses       2099     2103       +4     
Files with missing lines Coverage Δ
pertpy/metadata/_cell_line.py 52.75% <33.33%> (-0.60%) ⬇️

... and 1 file with indirect coverage changes

Copy link
Member

@Zethson Zethson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much!

Please ensure that your tutorials submodule is up to date. There should not be any changes to it in this PR.

This generally looks good!

Copy link
Member

@Zethson Zethson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you very much!

@Zethson Zethson merged commit da4169a into scverse:main Feb 26, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve UX for metadata module
3 participants