-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Align Mixscape with Seurat’s implementation #710
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…as perturbation markers
Zethson
approved these changes
Feb 19, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many great improvements! Thank you so much
This was referenced Feb 21, 2025
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
docs
is updatedDescription of changes
I made the following updates to
pt.tl.Mixscape()
:de_layer
parameter tomixscape()
, since DEG computation should be based onadata.X
, while the rest of the method operates onadata.layers[X_pert]
, i.e., the perturbation signature. Seurat’s implementation also includes this parameter (see here).test_method
parameter tomixscape()
andlda()
to specify the test used for DEG computation. Seurat uses Wilcoxon by default (see here), while pertpy previously always used a t-test. Hence, users can now choose their preferred method.scale
parameter tomixscape
. By default, Seurat scales DEG expression within the respective group (see here), so I introduced an option to enable this in pertpy too, which is set toTrue
by default.CustomGaussianMixture
model.mixscape()
fits a Gaussian Mixture Model to perturbed and non-perturbed cells, which is then used to assign cells to NP or KO. However, Seurat’s model fixes the mean and standard deviation for the NT distributions (see here), whereas Scikit-learn’sGaussianMixture
does not support this. Hence, so far, our implementation effectively fit two distributions instead of only one as in Seurat's case. To address this, I created aCustomGaussianMixture
class that inherits fromGaussianMixture
and overrides the M-step of the EM algorithm, allowing to fix certain mean and/or covariance values.