Skip to content

feat: euclid #208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 26 commits into from
May 9, 2025
Merged

feat: euclid #208

merged 26 commits into from
May 9, 2025

Conversation

greged93
Copy link
Collaborator

@greged93 greged93 commented May 4, 2025

Introduces required changes in order to support Euclid and Euclid v2 forks.

Signed-off-by: Gregory Edison <[email protected]>
Signed-off-by: Gregory Edison <[email protected]>
Signed-off-by: Gregory Edison <[email protected]>
Signed-off-by: Gregory Edison <[email protected]>
@greged93 greged93 marked this pull request as draft May 4, 2025 10:12
Copy link

codspeed-hq bot commented May 5, 2025

CodSpeed Performance Report

Merging #208 will not alter performance

Comparing feat/euclid (96e1f5b) with scroll (60ebed6)

Summary

✅ 77 untouched benchmarks

Signed-off-by: Gregory Edison <[email protected]>
greged93 added 2 commits May 5, 2025 13:06
Signed-off-by: Gregory Edison <[email protected]>
Signed-off-by: Gregory Edison <[email protected]>
@greged93 greged93 marked this pull request as ready for review May 6, 2025 09:36
@greged93 greged93 requested a review from frisitano May 6, 2025 09:37
Copy link
Collaborator

@frisitano frisitano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed proposed changes to the StateFetcher which @greged93 will explore.

greged93 added 4 commits May 7, 2025 09:22
Signed-off-by: Gregory Edison <[email protected]>
Signed-off-by: Gregory Edison <[email protected]>
Signed-off-by: Gregory Edison <[email protected]>
Signed-off-by: Gregory Edison <[email protected]>
@greged93 greged93 requested a review from frisitano May 7, 2025 07:36
Copy link
Collaborator

@frisitano frisitano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Left a question inline. I think we should wait to see how we proceed with the Euclid support in scroll-revm before merging this. Do you agree?

@@ -157,7 +158,7 @@ where
}
.into())
}
if tx.tx().is_eip7702() {
if tx.tx().is_eip7702() && !chain_spec.is_euclid_v2_active_at_timestamp(block.timestamp) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it euclid v2 or euclid v1 that activated eip7702?

Copy link
Collaborator Author

@greged93 greged93 May 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it should be v2, based on this PR as well.

greged93 added 4 commits May 7, 2025 14:52
Signed-off-by: Gregory Edison <[email protected]>
Signed-off-by: Gregory Edison <[email protected]>
Signed-off-by: Gregory Edison <[email protected]>
@greged93 greged93 requested a review from frisitano May 9, 2025 08:21
frisitano
frisitano previously approved these changes May 9, 2025
Copy link
Collaborator

@frisitano frisitano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! LGTM

Signed-off-by: Gregory Edison <[email protected]>
@greged93 greged93 merged commit 1c01514 into scroll May 9, 2025
46 checks passed
@greged93 greged93 deleted the feat/euclid branch May 9, 2025 13:03
@greged93 greged93 mentioned this pull request May 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants