Skip to content

Conversation

yiweichi
Copy link
Member

@yiweichi yiweichi commented Aug 5, 2025

Purpose or design rationale of this PR

Describe your change. Make sure to answer these three questions: What does this PR do? Why does it do it? How does it do it?

This PR adds license MIT OR Apache-2.0 for crate libzstd. It helps reth repo passing the CI check.

PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

  • build: Changes that affect the build system or external dependencies (example scopes: yarn, eslint, typescript)
  • ci: Changes to our CI configuration files and scripts (example scopes: vercel, github, cypress)
  • docs: Documentation-only changes
  • feat: A new feature
  • fix: A bug fix
  • perf: A code change that improves performance
  • refactor: A code change that doesn't fix a bug, or add a feature, or improves performance
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
  • test: Adding missing tests or correcting existing tests

Breaking change label

Does this PR have the breaking-change label?

  • No, this PR is not a breaking change
  • Yes

Summary by CodeRabbit

  • Chores
    • Updated license information in package manifests for improved clarity on licensing terms.

Copy link

coderabbitai bot commented Aug 5, 2025

Walkthrough

The license field was added to the Cargo.toml manifests for both the encoder-legacy and encoder-standard Rust packages, specifying "MIT OR Apache-2.0" as the licensing terms. No other modifications to functionality, dependencies, or configuration were made.

Changes

Cohort / File(s) Change Summary
Cargo.toml License Field Addition
libzstd/encoder-legacy/Cargo.toml, libzstd/encoder-standard/Cargo.toml
Added license = "MIT OR Apache-2.0" to each Cargo.toml manifest. No other changes.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

Two crates now wear their license proud,
MIT or Apache—declared out loud.
No code has changed, no logic bent,
Just words of law, with good intent.
The bunnies hop, their work is done—
Open source joy for everyone! 🐇✨

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2cfec8c and 2ed98a7.

📒 Files selected for processing (2)
  • libzstd/encoder-legacy/Cargo.toml (1 hunks)
  • libzstd/encoder-standard/Cargo.toml (1 hunks)
🔇 Additional comments (2)
libzstd/encoder-legacy/Cargo.toml (1)

5-5: License declaration LGTM

The SPDX‐compatible expression looks correct and unblocks CI. 👍

libzstd/encoder-standard/Cargo.toml (1)

5-5: License declaration LGTM

Same as in encoder-legacy; the crate now clearly states dual MIT / Apache-2.0 licensing.

✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch add-license-for-libzstd

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@yiweichi yiweichi requested review from lispc and colinlyguo August 5, 2025 19:50
@yiweichi
Copy link
Member Author

yiweichi commented Aug 5, 2025

Not sure If we want to add a license for it. If not we can bypass it on the Reth CI part.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants