fix: conditional variable definition in num_threads
#896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hero78119
reviewed
Apr 4, 2025
| @@ -1,7 +1,13 @@ | |||
| pub fn num_threads() -> usize { | |||
There was a problem hiding this comment.
Giving another similar TODO issue #861
I would suggest make this PR with slightly wider scope: remove this parallel.rs file and leverage plonky3 maybe-rayon to achieve the same functionality
There was a problem hiding this comment.
we will in favour of this solution instead #897, for parallel.rs is some previous left-over and we will clean it up eventually
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I fixed a problem in the
num_threadsfunction. The original code used#[cfg(feature = "parallel")] let nt = rayon::current_num_threads();, which caused an issue because the variablentwould only be defined if theparallelfeature was active. This led to a compilation error when the feature was disabled, as the compiler couldn't findnt.Now, the function properly returns the correct value based on whether the
parallelfeature is enabled or not, avoiding the issue where the variablentwasn't always available.