Mihai/keccakf integration #893
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove buffers and replace the underlying util functions. Add comments and fix some tiny bugs Suggestions for 'Frontend and backend for building circuits' (scroll-tech#801) Suggestions for scroll-tech#799 Feel free to pick and choose from the suggestions. I talk about most of them on your PR. --------- Co-authored-by: dreamATD <[email protected]> Refine according to comments refine the protocol prover and verifier structs Add more comments Tiny fix according to the latest comments.
mcalancea
force-pushed
the
mihai/keccakf_integration
branch
from
77c289e to
fce4a2c
Compare
mcalancea
force-pushed
the
mihai/keccakf_integration
branch
from
fce4a2c to
7611e70
Compare
spherel
reviewed
Apr 3, 2025
mcalancea
force-pushed
the
mihai/keccakf_integration
branch
from
26d44d6 to
1cedbc8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.