Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frontend and backend for building circuits #799

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

dreamATD
Copy link
Collaborator

@dreamATD dreamATD commented Dec 31, 2024

This is an implementation of the expression-based and plonkish-like GKR IOP protocol. The circuit is denoted as Chip, holding all information to process commit phases and GKR proving phase. In the current implementation, we assume there are two commit phases. To process the GKR phase, we extract a GKRCircuit from it and run the GKR protocol. For the implementation status, the GKR phase is ready for review, while the commit phases hasn't been finalized.

Define a GKR IOP protocol for a chip includes defining build_commit_phase, build_commit_phase2 and build_gkr_phase. Specially, build_gkr_phase is mainly to build GKR layers in the reverse order. In addition to specify the expressions, to simplify the case of either transferring evaluations from an input of a succeeding layer to an output of the current layer or even make some computations before feeding to the current layer, we use an evaluation tape to place the evaluations and EvalExpression to define the computation. Each layer input will be assigned a position in the evaluation tape. EvalExpression is defined as follows:

#[derive(Clone, Debug)]
pub enum EvalExpression {
    Single(usize),
    Linear(usize, Constant, Constant),
    Partition(Vec<Box<EvalExpression>>, Vec<(usize, Constant)>),
}

of which the items denote how to compute the output evaluations. For more details please refer to gkr_iop/src/evaluation.rs.

Here are some subsequent tasks:

  • Parallelize the vector evaluations under subprotocols/src/expression/.
  • Devirgo migration.
  • Benchmarks.
  • Keccak example and benchmarks.

Although the previous tasks should be done, I suggest to start the first round of review first. Would like to see comments from @naure and @hero78119 so that I can adjust the design before moving forward.

Upd: The design doc: https://hackmd.io/@sphere-liu/HyLR-h2L1g.

@dreamATD dreamATD requested review from hero78119 and naure January 1, 2025 02:37
@dreamATD dreamATD force-pushed the tianyi/refactor-prover branch 2 times, most recently from dc664af to 929eddf Compare January 1, 2025 03:46
@kunxian-xia kunxian-xia self-requested a review January 2, 2025 08:50
@matthiasgoergens matthiasgoergens self-requested a review January 2, 2025 08:52
@dreamATD dreamATD linked an issue Jan 6, 2025 that may be closed by this pull request
dreamATD added a commit that referenced this pull request Jan 6, 2025
Suggestions for #799

Feel free to pick and choose from the suggestions. I talk about most of
them on your PR.

---------

Co-authored-by: dreamATD <[email protected]>
Copy link
Collaborator

@naure naure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First pass on gkr_iop. It makes sense so far.

Comment on lines 55 to 59
// TODO: the following trait consists of `commit_phase1`, `commit_phase2`, `gkr_phase` and `opening_phase`.
pub trait ProtocolProver<E: ExtensionField, Trans: Transcript<E>, PCS> {}

// TODO: the following trait consists of `commit_phase1`, `commit_phase2`, `gkr_phase` and `opening_phase`.
pub trait ProtocolVerifier<E: ExtensionField, Trans: Transcript<E>, PCS> {}
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@naure If I will implement those traits for Chip later, do you still think it's better to rename Chip to be CircuitBuilder?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or just add a /// comment that explains all the responsibilities of the Chip type?

@dreamATD dreamATD force-pushed the tianyi/refactor-prover branch from 16b57f3 to 29061f1 Compare January 9, 2025 11:30
dreamATD added a commit that referenced this pull request Jan 15, 2025
Suggestions for #799

Feel free to pick and choose from the suggestions. I talk about most of
them on your PR.

---------

Co-authored-by: dreamATD <[email protected]>
@dreamATD dreamATD force-pushed the tianyi/refactor-prover branch from cffdd03 to d51562b Compare January 15, 2025 01:20
/// Chip stores all information required in the GKR protocol, including the
/// commit phases, the GKR phase and the opening phase.
#[derive(Clone, Debug, Default)]
pub struct Chip {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can separate ChipBuilder vs ConstrainSystem.
Refer similar design in ceno_zkvm https://github.com/scroll-tech/ceno/blob/master/ceno_zkvm/src/circuit_builder.rs#L487-L488
All the information store in this chip struct should belong to ConstrainSystem.
So it can be Serializable.

similar as commment here https://github.com/scroll-tech/ceno/pull/799/files#r1904053980


/// Vector of field type.
#[derive(Clone, PartialEq, Eq)]
pub enum VectorType<E: ExtensionField> {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can reuse FieldType as it's exactly same functionality

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, can I rename it to be VectorType?

}
}

pub fn calc<E: ExtensionField>(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should avoid heavily vector clone internally, by wrap into Rc or Arc so we only clone pointer
Also we should improve it with parallel version to boost the performance

Copy link
Collaborator Author

@dreamATD dreamATD Jan 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there any "parallel clone"? Here I only clone for single vector, of which the space will be reused when applying operations, such as follows:

define_commutative_op_mle2!(VectorType, Add, add, |x, y| {
    zip_eq(&mut x, y).for_each(|(x, y)| *x += y);
    x
});

Copy link
Collaborator

@hero78119 hero78119 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome job!
I leave few comments in separate section due to large PR so I did the review in segmented time.

Most of the utility of code reused can be done later, I think the most important point might be trying one pre-compile (e.g. keccak-f) first, and benchmark the preliminary performance. Once it meet the requirements, we proceed to more engineering polishing works :)

@dreamATD dreamATD force-pushed the tianyi/refactor-prover branch 2 times, most recently from 7762988 to 87d1a30 Compare January 15, 2025 13:32
@dreamATD dreamATD force-pushed the tianyi/refactor-prover branch from 87d1a30 to 88f9b00 Compare February 19, 2025 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

frontend design for precompiles
4 participants