Skip to content

#1061 cleanup #1106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kunxian-xia merged 6 commits into from
Oct 31, 2025
Merged

#1061 cleanup #1106

kunxian-xia merged 6 commits into from
Oct 31, 2025

Conversation

@kunxian-xia
Copy link
Collaborator

@kunxian-xia kunxian-xia commented Oct 31, 2025 •
edited
Loading

#1061 Cleanup

  • clippy fixes
  • remove old unused routines for generating witness for the ecc summation tower tree. Note this approach is abandoned. We prefer to pack $log_2(N)$ layers in one layer using the relation p[1, b] = ec_add(p[0,b], p[1,b]) (first proposed in Quark paper.

hero78119
hero78119 reviewed Oct 31, 2025
View reviewed changes
hero78119
hero78119 approved these changes Oct 31, 2025
View reviewed changes
Copy link
Collaborator

@hero78119 hero78119 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kunxian-xia kunxian-xia merged commit 9917b61 into feat/septic_global_chip Oct 31, 2025
3 of 4 checks passed
@kunxian-xia kunxian-xia deleted the feat/septic_global_cleanup branch October 31, 2025 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hero78119 hero78119 hero78119 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kunxian-xia @hero78119