Additional testing for changes due to rayon being replaced by p3::maybe-rayon #1080
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
#861
This is a test PR to check the changes made in the gkr-backend PR. The dependencies in the
Cargo.toml
here are pointing to thefeat/p3-maybe-rayon
branch.Status
cargo make tests
The tests are working completely fine .
cargo bench -p ceno_zkvm
benches/bitwise_keccakf.rs
is giving an error for both the master branch and this branchtest/p3-maybe-rayon
, rest all are same.Now for comparing the traces for both the cases, I was confused about which tests to change that use rayon and would show the difference in the stack trace.