fix(3433): PR jobs displayed even when “Show PR Jobs” is enabled #1510
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minghay
requested changes
Dec 2, 2025
| import { nodeCanShowTooltip } from 'screwdriver-ui/utils/pipeline/graph/tooltip'; | ||
|
|
||
| export default class PipelineWorkflowGraphComponent extends Component { | ||
| @service pipelinePageState; |
Contributor
There was a problem hiding this comment.
Suggested change
| @service('pipeline-page-state') pipelinePageState; | |
| @service ('settings') settings; |
It would be best to inject the settings instead of having it passed as an argument on the component. By injecting the settings, when the graph component is initially rendered it will always use the correct settings (i.e., navigating to the events UI view). Doing this will also mean you do not need to modify the workflow component and template.
You can choose to store the showPRJobs into a class variable in the constructor to avoid having to extract it each time in the getDecoratedGraph function.
minghay
requested changes
Dec 3, 2025
minghay
requested changes
Dec 4, 2025
Co-authored-by: Ming-Hay <[email protected]>
Co-authored-by: Ming-Hay <[email protected]>
Co-authored-by: Ming-Hay <[email protected]>
minghay
approved these changes
Dec 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Fixes the issues with this problem
screwdriver-cd/screwdriver#3433
The “Show PR jobs” option is not working on V2 UI
Objective
When hidden, workflows starting with ~pr are not displayed.
References
screwdriver-cd/screwdriver#3433
License
I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.