Skip to content
This repository was archived by the owner on Aug 12, 2022. It is now read-only.

save sprite name empty if it's empty #524

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

save sprite name empty if it's empty #524

wants to merge 2 commits into from

Conversation

yueyuzhao
Copy link
Contributor

@yueyuzhao yueyuzhao commented Oct 6, 2021 •
edited
Loading

Resolves

Proposed Changes

save sprite name empty if it's empty

Reason for Changes

If users set the sprite name to empty, the old name will get back.

Test Coverage

  • set sprite name to empty
    • iPad mini 2 (iOS 12.5)
    • Kindle Fire HD 8 (Android 5.1)

@chrisgarrity chrisgarrity self-assigned this Oct 6, 2021
@yueyuzhao yueyuzhao marked this pull request as ready for review October 12, 2021 12:06
@deepankarmalhan
Copy link
Contributor

SJR-161

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

@chrisgarrity chrisgarrity

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Renaming characters should not copy the name from a different character

3 participants

@yueyuzhao @deepankarmalhan @chrisgarrity