-
Notifications
You must be signed in to change notification settings - Fork 82
[UEPR-56, UEPR-282] Integration branch for React 18 and Face Sensing #350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
* avoid gl.readPixels at all costs
Scale the drawable scale by the ratio of pixel size to native size.
Layer ordering
Add API for getting the drawable order of a given drawable.
…use pointer (#325) * Allow 'isTouching' and 'pick' to still work on invisible drawables. * Always ignore visibility for isTouching on drawable * Filter invisble drawbles in isTouchingDrawable per rules of collision * polish up some docs/get logic 👍 * leftover line from deleted comment * revert to ghosted pick behavior * Add clientSpaceToScratchBounds method * fix lint * add some pick tests
* Touching color draft implementation * New constant for CPU/GPU render split determined, removing query param * Small fix for pick tests
* draw pen skin lines and stamps to a framebuffer * skip reading pixels and draw stamp to framebuffer * update silhouette with readPixels * draw pen canvas to buffer when its dirty Composite lines and stamps on browser preferred side (cpu/gpu) until the export texture is needed. Then blend the canvas with the current buffer contents. Updating this way invalidates useProgram optimization and the renderer currently does not have a way to know this. * draw lines on framebuffer through fragment shader * optimize draw regions and pen skin matrix creation * control draw regions * mobile gpus need high precision floats for line drawing * optimize cpu pen line math * sampled pen line caps * sampleless pen skin lines, lint, document pen skin buffer ops * add PenSkin._canvasDirty to constructor * remove DRAW_MODE_line * comment PenSkin reused memory, use memory in drawRectangle * turn draw region id's into optional method handlers A region ID object may have an enter and exit method on it that are used by default when entering and exiting that region. * remove old DRAW_MODE_line precision setting * standardize vert lines on 4 spaces * fixup! turn draw region id's into optional method handlers * do not draw when updating pen skin silhouette * do not premultiply stamp colors by alpha * fixup! do not draw when updating pen skin silhouette * do not premultiply line color * add a small rim around the line for aliasing * variable pen line alias amount * reverse offset pen line on y axis by relative alias amount Reverse the offset to keep small line overlap to a minimum. * fixup! reverse offset pen line on y axis by relative alias amount * medium precision gpu floats
Add getter for the renderer's canvas
Add ability to get a snapshot of the next frame
Fix bug when bounds would be infinite and cause never ending loop
Fix touching mouse
Fix uncaught error `cannot find property updateSilhouette of null`
Increase maximum texture size and back it off if GL fails to render
Revert "Increase maximum texture size and back it off if GL fails to render"
Implement updateSilhouette to allow updates to happen when needed
Revert "Merge pull request #394 from paulkaplan/defer-silhouette-upda…
Add inset logic that is closer to Scratch 2's inset
Update silhouette after getting texture at a new scale
Fix extraction of drawable to not clip bounds.
Adjust CPU isTouchingColor to match GPU results
Revert "Adjust CPU isTouchingColor to match GPU results"
Use Math.ceil and Math.floor to match Scratch 2 logic
Compatibility fix for bitmap position off stage
Add "query playground"
ImageData WebGL Textures
Adjust CPU `isTouchingColor` to match GPU results (again)
Revert "Adjust CPU `isTouchingColor` to match GPU results (again)"
pen transparency fix
Implement canvas-based TextBubbleSkin
…bnail Fix: Change face sensing tutorial thumbnail
…clickable [UEPR-385] Fix sprites issues when extension button tooltip is displayed
…crashes [UEPR-386] Sound editor crashes
…callout-not-hiding [UEPR-287] Update new feature callout behavior in extensions modal
…-editor into UEPR-56-UEPR-282
…scratch-editor into UEPR-56-UEPR-282
…een-flag [UEPR-390] Fix: Allow pointer events on green flag button
…scratch-editor into UEPR-56-UEPR-282
… into UEPR-56-UEPR-282
… into UEPR-56-UEPR-282
I have read the CLA Document and I hereby sign the CLA 1 out of 9 committers have signed the CLA. |
Test report for scratch-gui 2 files ±0 62 suites +1 10m 16s ⏱️ + 1m 25s Results for commit fcf19b7. ± Comparison against base commit 83c402b. This pull request removes 18 and adds 27 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
… into UEPR-56-UEPR-282
… into UEPR-56-UEPR-282
Integration branch, including changes for: