-
Notifications
You must be signed in to change notification settings - Fork 74
Upgrade scratch-editor to use React 18 #299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
…ct-tooltip back to 4.5.1
…le buttons, save status
…fix broken projects on PDP
…igration [UEPR-326] Fix issues after react migration
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
_wm,
=Wqc. .uZ(3L
=#>?$a. <d1=+)m.
:#=|=?Sw, _wY|+++|dc
dc=+++)Vq,. .__aawwwowwwaZ(++++|=]C
3c|+++++|TmpXTY!|+==++=+|++|=|+++<m;
]k++++|=+=====+++++|=|+++++++++++|3w,
)h+++++++|++|++++++++++++++++++++++*Sa.
:#>+|++++++++++|++|=|=++|++|++iwZSXw%?mc
.$>+=++|++|<a%|=++++++|=+++++vZ^ -YSz9a.
dc=|++++aZ?!!Yqa=|+++++++|=|d( -4o3h,
.dc+++++nZ` -?mc=++++|++++d; 3o36.
.jC|+++||d~ -Sa|++|=+++|3c 4z3z
jE=+++++|m: 9z++++++++)m. _a.:$%m,
<Z=+++|+++X; -$%=|=|++|+3o =QWC.3z3c
.m(++|=+++|3L jgc ]k=+++++++|Va -?T^ 3e<m.
.. jC+++++++++=$c :$Wk )k=++++++++=3q, .m++Ta,. .
)Tqa%di++|++|+++|+Sc -"` ]k=+|+|iaaaa%)Vqa,__m( !Ya. _w2
~4#ga>=+++++++++9w, .d(-:=<mWWBWWWQc-"??!` +5,.__saZ?^
]k+?$w%++++|== "Ywa,aad( ?WWWWBW#` )$ZY?"`
]k=+=)T(++++- "!"^ ~Y$BWD^ :6.
)k++|++++|+; . -^ .d;
.waaamwawwZ1++=` )ZSwa,,_ . _wd;.
--~3Z||=++++= ]C "!YYSXqwassssaaaaw, ]DYYXXqqo.
-Sc+|++++= )k --^^^^~-:d' .d(
-$c+++|++. :m. .j[ je
-9a=|=++; 3c .w! .je
9q%=|=+. 9a. .aZ^ <d(
"Sw=|++: !Sa,_ .__wZ! _wY`
"Sw%++=. "!?YS2YY?!~ _ap?'
_uWmws==. __adY^
.adT?*|!Y$mwa=,_. ..__sauXY!~
_uoa. _aZ?|=|=++=vE*!TVUXmqwwawuavSYY?!"~
)P` "h, _uZ*++=+++|+<d1==++=++=+||3g, .
d` +G, <#*+=++|=|==aZ1+++|=|+++++=vDAc .swXma,
k +G, <D++++|=++<amY|++++=----=++|nk=Yq, <Z?+==*$;
k. +G, ]C+++|=+|adY+=++++= =<dc++)YqawY|++|++3C
S; -$c ]h=|++++|Xz=+++++= jE=++++|+|++++++i#`
]L ._===Sa, $c++++++)$c+|++|. =ma=|+++++++++|+vZ'
4c .|++|++*Aa,,-$%=+|+++)$c=+++= _d(Yqc+++++|++|<wY`
-4c=+++++++=*YVmwm%=+++++)m>=|=+=. _d( ~?ma%|||iawT^
?m%++++++|====|*$c=+|++{#=|=+|+|; <Z' -"??Y??"~
-?ma>|+++++|+++|Sga|iumk>+++++=+|)B;
-"YSqwas%iiiswZ!?YT!|?$a=|++|+++)$a.
^"""Y$BY}=+++=+++|Ym%+++++++=?m,
_waa__wZT*=+=++++|++<swY4w>++++|++)Va.
jE|+*?Yi=+++|++|+++iwd!` "Aa=|+=++++?m,
:#=++++++++++++++<am?" ?m%=+|++++|9g,
Xc+|=|=++|++<swdY"` ~So>=++|+++)Sa, ..
)h=|=++|=+imY!~ ?mc++++++++?$wXXSXXXwa%.
4o++++++|)m, -4w>+++++++=====+=++|?Ac
-Va+|+++++{m. "$a=|++|++|+|++|++|=|$;
-4o>=+|=++3c -?mc=++++++=+++++++|d;
?q%+++|+d[ -4w%=++++|+++++|swe
~4qaiauZ` "9qwwawaaawumY!~
id="gui.unsupportedBrowser.previewfaqlinktext" | ||
/> | ||
), | ||
a: previewFaqLink => ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was thinking about suggesting that a
should be named something more distinctive so that it's more obvious what's going on when reading this code. On the other hand, I think <a>
makes it easier to understand the value of defaultMessage
, so maybe this is the best choice. Hmm.
At any rate, I'm not recommending any changes to this right now, just "thinking out loud" about being friendly to folks who are familiar with scratch-gui
prior to React 18 vs. being friendly to folks who work in Transifex. I don't currently see a clear way to avoid this being a tradeoff. :shakes_fist_at_clouds:
A clone of #139
Resolves
https://scratchfoundation.atlassian.net/browse/UEPR-56
Proposed Changes
Update scratch-editor to use React 18. Upgrade versions of dependencies where needed.
Reason for Changes
React 16 is increasingly being deprecated by libraries we user - we need this to ensure some adequate level of support.
Test Coverage
Updated tests where this was necessary