Add commitlint #77
Merged
Add commitlint #77
+1,462
−73
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On non-release branches, it will automatically do a dry run
MichalPawlicki
approved these changes
Feb 6, 2025
| @@ -15,11 +15,7 @@ jobs: | |||
| - name: Run Tests | |||
| run: npm test | |||
| - name: Semantic Release | |||
| if: github.ref_name == 'master' | |||
There was a problem hiding this comment.
Can we remove the condition? Won't it result in publishing a release on every push to every branch, e.g. develop?
There was a problem hiding this comment.
semantic-release has a config file that controls which branches it publishes from. If it runs against a branch that isn't in the release config, it'll do a dry run. I like to enable that since it can help highlight changes that break semantic-release before they're merged.
|
🎉 This PR is included in version 2.4.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Add
commitlintas adevDependencyand hook it up to run at commit time and on pull requests.Reason for Changes
This will help make sure
semantic-releasecan generate a change list for releases.Test Coverage
Tested by making this PR :)