Skip to content

feat(#52): add set_registration_contract and player existence check in approve_milestone - #142

Open
had3sgames wants to merge 2 commits into
scout-off:mainfrom
had3sgames:issue-52-approve-milestone-player-existence-check
Open

feat(#52): add set_registration_contract and player existence check in approve_milestone#142
had3sgames wants to merge 2 commits into
scout-off:mainfrom
had3sgames:issue-52-approve-milestone-player-existence-check

Conversation

@had3sgames

Copy link
Copy Markdown
Contributor

(issue-52-approve-milestone-player-existence-check)

  • Added registration_contract module via contractimport!
  • Added set_registration_contract(env, addr) admin function
  • approve_milestone: if DataKey::RegistrationContract is set, calls
    reg_client.try_get_player(&player_id) and returns PlayerNotFound on failure;
    skipped if not set
  • Tests: skip path (no reg contract) and panic path (reg contract set, unknown
    player)

closes #52

@drips-wave

drips-wave Bot commented May 27, 2026

Copy link
Copy Markdown

@had3sgames Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

approve_milestone should verify player exists via registration contract

1 participant