Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the issue where root detection not working for android 14+ Emulators #242

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

yeshwanthsai1010
Copy link

Issue Summary

Starting with Android 14, emulators no longer provide access to the ro.debuggable and ro.secure properties, as noted in this issue. These properties were critical for our root detection logic, and their unavailability has caused our root detection to fail on Android 14+ emulators.

As our team primarily relies on rooted emulators for testing, this issue has disrupted our workflows and impacted testing capabilities.

Investigation

To address this, I explored alternative properties that could reliably indicate rooted devices. During this process, I came across this discussion on XDA, which suggested using the ro.adb.secure property. This property appears to be a reliable substitute for detecting rooted devices in Android 14+ environments.

Proposed Solution

This pull request modifies our root detection logic to include the ro.adb.secure property as an alternative check when ro.debuggable and ro.secure are unavailable. This ensures that our root detection continues to function properly on Android 14+ emulators.

Benefits

  • Restores root detection functionality on Android 14+ emulators.
  • Allows the team to continue using rooted emulators for testing purposes.
  • Maintains compatibility with older Android versions without impacting existing behavior.

Request for Review

I kindly request you to review and approve this pull request so that we can resolve the issue and resume testing on rooted emulators seamlessly.

Developer checklist

  • Run the app and tested the new/edited functionality to conform to the expected behaviour
  • Run the following ./gradlew test and confirmed all tests pass.

@yeshwanthsai1010 yeshwanthsai1010 changed the title Fixed the issue where root detection not working for android 14+ Emul… Fixed the issue where root detection not working for android 14+ Emulators Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant