Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat] Reset password to null #907

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

BLasan
Copy link

@BLasan BLasan commented Mar 24, 2020

Description
After an unsuccessful login password have to be reset to null with highlighting the password container. Form validations are added and the login button will enable only if both user name and password are provided.

Related Issue
#906

Motivation and Context
Password will be reset to null after an invalid login.

How Has This Been Tested?
Manually tested by inputting wrong credentials.

Screenshots (In case of UI changes):
bassa1

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@BLasan BLasan force-pushed the resetPasswordToNull branch 4 times, most recently from 30fee72 to 02a015d Compare March 29, 2020 16:39
@BLasan
Copy link
Author

BLasan commented Mar 29, 2020

@kmehant Please review the PR

PR-quality resolved

form validations added
@BLasan
Copy link
Author

BLasan commented Feb 21, 2021

@kmehant Please review

@grwt
Copy link

grwt commented Nov 24, 2023

why it isn't merged yet? is this still open...????

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants