Skip to content

chore(implementations): add init --no-default-provisioners flag description #168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

lekaf974
Copy link
Contributor

@lekaf974 lekaf974 commented Apr 6, 2025

Thank you for submitting this pull request! We appreciate you spending the time to work on these changes.

What is the motivation?

Update documentation based on changes done in score-k8s adding --no-default-provisioners flag in init command

What does this change do?

Provide a description of what this pull request does.

Add --no-default-provisioners flag description

What is your testing strategy?

Is this related to any issues?

Related to score-spec/score-k8s#148 and needs score-spec/score-k8s#150 to be merged

If this pull request is related to any other pull request or issue, or resolves any issues - then link all related pull requests and issues here.

Have you read the Contributing Guidelines?

@lekaf974
Copy link
Contributor Author

lekaf974 commented Apr 6, 2025

@mathieu-benoit mathieu-benoit self-requested a review April 6, 2025 14:49
@mathieu-benoit mathieu-benoit marked this pull request as draft April 6, 2025 14:49
@mathieu-benoit
Copy link
Contributor

Converting as Draft for now because depending on score-spec/score-k8s#150.

@lekaf974 lekaf974 marked this pull request as ready for review April 15, 2025 01:50
@lekaf974
Copy link
Contributor Author

@mathieu-benoit, moving to ready for review since the PR has been merged

@mathieu-benoit
Copy link
Contributor

Good point, seeing this CI error to fix please:

from /home/runner/work/docs/docs/content/en/docs/score implementation/score-k8s/cli.md:
61 61| score-k8s·init·--provisioners·[https://raw.githubusercontent.com/user/repo/main/example.yaml·--no-default-provisioners](https://raw.githubusercontent.com/user/repo/main/example.yaml%C2%B7--no-default-provisioners)
62 62| ```
63 63| 
   64|-
64 65| ####·`--help`·|·`-h`
65 66| 
66 67| Displays·help·information·for·`init`,·providing·a·short·description·of·the·command·along·with·examples·and·compatible·flags.
--
Found 1 not formatted file.
error Command failed with exit code [20](https://github.com/score-spec/docs/actions/runs/14287384790/job/40058073464?pr=168#step:7:21).

@lekaf974 lekaf974 force-pushed the chore/update-init-after-add-no-default-provisioner-flag-score-k8s branch from edcab12 to 4314bd5 Compare April 17, 2025 01:34
@lekaf974
Copy link
Contributor Author

changes pushed

@mathieu-benoit mathieu-benoit changed the title chore(score-k8s-init): add --no-default-provisioners flag description chore(implementations): add --no-default-provisioners flag description Apr 17, 2025
@mathieu-benoit mathieu-benoit changed the title chore(implementations): add --no-default-provisioners flag description chore(implementations): add init --no-default-provisioners flag description Apr 17, 2025
Copy link
Contributor

@mathieu-benoit mathieu-benoit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lekaf974, let's do it for score-compose too, right?

Now released too: https://github.com/score-spec/score-compose/releases/tag/0.27.1

@lekaf974
Copy link
Contributor Author

did not remember if it has been done in score-compose !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants