feat(doas): new completion #766
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tachi107
reviewed
Apr 16, 2024
|
Makes sense, thanks for the explanation!
|
akinomyoga
reviewed
Sep 1, 2025
| if [[ ${words[i]} != -* ]]; then | ||
| local PATH=$PATH:/sbin:/usr/sbin:/usr/local/sbin | ||
| local root_command=${words[i]} | ||
| _command_offset $i |
There was a problem hiding this comment.
In a similar way to_comp_root_command() (defined in bash_completion), I think we want to enable the completion as if the current user has root privilege.
Suggested change
| _command_offset $i | |
| local _comp_root_command=1 | |
| _command_offset $i |
|
In case, the upstream issue is Duncaen/OpenDoas#62. The upstream PR is Duncaen/OpenDoas#84. |
|
The upstream issue and patch have been ignored for four years. I think that's enough evidence of lack of interest from upstream |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #505