feat(_comp_compgen_help): enhance for smartctl

[chrfranke]

A followup to #1425 with two commits addressing independent topics.

Should now detect these properly:

  -n MODE[,STATUS[,STATUS2]], --nocheck=MODE[,STATUS[,STATUS2]] (ATA, SCSI)
  -s NAME[,VALUE], --set=NAME[,VALUE]
  -B [+]FILE, --drivedb=[+]FILE                                       (ATA)

[chrfranke]

I don't think it's worth such a complication. What I had in mind is to allow + as one of the possible characters in the option-argument description...

Force-pushed new version of 2nd commit.

[akinomyoga]

LGTM

[chrfranke]

Sorry for CI failures. Will address these in the next days.

[chrfranke]

Force-pushed new version, now combined in one commit. This reformats (as suggested by pre-commit) and fixes the testcases.

--- a/test/t/unit/test_unit_parse_help.py
+++ b/test/t/unit/test_unit_parse_help.py
@@ -205,15 +205,19 @@ class TestUnitParseHelp:

     def test_33(self, bash):
         """Pattern found in the output of 'smartctl --help'."""
-        assert_bash_exec(bash, "fn() { echo '-f A1[,A2[,A3]] --foo=A1[,A2[,A3]]'; }")
+        assert_bash_exec(
+            bash, "fn() { echo '-f A1[,A2[,A3]] --foo=A1[,A2[,A3]]'; }"
+        )
         output = assert_bash_exec(bash, "_parse_help fn", want_output=True)
-        assert output.split() == "--foo".split()
+        assert output.split() == "--foo=".split()

     def test_34(self, bash):
         """Pattern found in the output of 'smartctl --help'."""
-        assert_bash_exec(bash, "fn() { echo '-f [+]ARG --foo=[+]ARG'; }")
+        assert_bash_exec(
+            bash, "fn() { echo '-f [+]ARG --foo=[+]ARG'; }"
+        )
         output = assert_bash_exec(bash, "_parse_help fn", want_output=True)
-        assert output.split() == "--foo".split()
+        assert output.split() == "--foo=".split()

     def test_custom_helpopt1(self, bash):
         assert_bash_exec(bash, "fn() { [[ $1 == -h ]] && echo '-option'; }")

[chrfranke]

Obviously my assumption about max allowed title length (4 indentation + 74 title = 78) was wrong. Force-pushed a new version using the original title of this PR. The code is unchanged.

[chrfranke]

Undoing reformatting of test_34. Last try for this week to make pre-commit happy :-)

[akinomyoga]

The CI error in fedoradev seems to have started to happen after the latest update-docker-images and is unrelated to this PR.