fix(cd): generate only cdable_vars containing valid directory paths #1361
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scop
requested changes
Apr 9, 2025
This code appears to try to suffix "/" when the unique completion of a directory name does not end with "/". However, the test compares the completion with the quoted `"*/"`, which does not work as expected. If the generated directory name already ends with "/" (though it is unclear whether it may happen except for "/"), this code would result in double slashes such as "dir//". This double-quoted pattern is present from the beginning when this code was introduced in commit a1969bd. This patch removes the double quoting so that the directory name is correctly matched with the pattern `*/`.
To apply the adjustment of suffixing "/" only to the completions generated based on CDPATH, we isolate the CDPATH completion code in a separate generator. This is needed because we want to generate cdable_vars completions into COMPREPLY, but we do not want to apply sufixing to the cdable_vars completions.
akinomyoga
force-pushed
the
cdable_vars-filter
branch
from
d070a04 to
5e9f8d4
Compare
Co-authored-by: Ville Skyttä <[email protected]>
akinomyoga
force-pushed
the
cdable_vars-filter
branch
from
5e9f8d4 to
355eb4d
Compare
scop
approved these changes
Apr 9, 2025
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
shopt -s cdable_varsis set, all the variable names are generated as completions. For example, in my environment,However, most of them do not contain valid directory names, so they do not work even if they are specified to the argument of
cd. In this PR, I try to filter only the variables that contain a valid directory path. After this change, the above result is changed to the following:I also include other minor fixes and refactoring in separate commits.