fix(mdtool,rcs,etc): fix uses of -G 'pat' and -f -X '!pat'
#1358
+23
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There is still an issue with One of the reasons that some of the completion setting use
|
akinomyoga
changed the title
-G 'pat' and -f -X '!pat'-G 'pat' and -f -X '!pat'
There was a problem hiding this comment.
Copilot reviewed 1 out of 7 changed files in this pull request and generated no comments.
Files not reviewed (6)
- completions/feh: Language not supported
- completions/mdtool: Language not supported
- completions/rcs: Language not supported
- completions/upgradepkg: Language not supported
- completions/valgrind: Language not supported
- test/runLint: Language not supported
scop
approved these changes
Apr 9, 2025
In the current implementation, when the current word contains any glob characters, the glob pattern can match unexpected files. We instead use `_comp_expand_glob` with double-quoting the strings originating from the current word.
The original code (which is commented out and marked as TODO) tried to perform the filename generation by specifying both `-f` and `-G`, and also specifying `-G` multiple times. This has the following issues: * The completion specification of `-f` and `-G` are independent, so this code is going to generate all filenames with `-f`. Then, it additionally generates the filenames matching the specified pattern. * The `-G pat` can only be specified once, or the latter `-G pat` specification will overwrite the previous specification. We should combine multiple patterns into one. Note: This code stub was originally introduced in commit 73225ea. In this patch, we remove `-f` and merge multiple `-G`.
scop#1297 (comment) The compgen option `-X '!pat'` has a problem that it only generates the filenames in the current directory and that it does not perform the filtering by the "cur" specified to the argument of `compgen`: $ compgen -G '*.md' -- doc/ CHANGELOG.md CONTRIBUTING.md README.md style.md In this patch, we use `-f -X '!pat'`, which does not have those limitations.
akinomyoga
force-pushed
the
compgen-G
branch
2 times, most recently
from
e98f1a7 to
72f745f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses issues discussed in #1297. This PR also includes other changes. See the commit messages.
_comp_compgen -C#1297 (comment)_comp_compgen -C#1297 (comment)