Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support PHP 8.2 version for Fedora container #421

Merged
merged 4 commits into from
Aug 25, 2023
Merged

Conversation

phracek
Copy link
Member

@phracek phracek commented Aug 23, 2023

This pull request adds support for PHP version 8.2.

  • Source are moved from 8.1 to 8.2 by git mv
  • Version is copied back 8.2 -> 8.1
  • Correct PHP version in directory 8.2 from PHP 8.1 to PHP 8.2

Preserve git history

Signed-off-by: Petr "Stone" Hracek <[email protected]>
Signed-off-by: Petr "Stone" Hracek <[email protected]>
@phracek
Copy link
Member Author

phracek commented Aug 23, 2023

First test

[test]

@phracek
Copy link
Member Author

phracek commented Aug 23, 2023

@remicollet @hhorak @pkubatrh Can you please review it? Only Fedora PHP-8.2 version is tested. Everything else has .exclude files. Thanks

@remicollet
Copy link
Contributor

LGTM
Perhaps missing php.ini changes (but only about new max_multipart_body_parts)

@@ -425,6 +425,11 @@
 ; How many GET/POST/COOKIE input variables may be accepted
 ;max_input_vars = 1000
 
+; How many multipart body parts (combined input variable and file uploads) may
+; be accepted.
+; Default Value: -1 (Sum of max_input_vars and max_file_uploads)
+;max_multipart_body_parts = 1500
+
 ; Maximum amount of memory a script may consume
 ; https://php.net/memory-limit
 memory_limit = 128M

@phracek
Copy link
Member Author

phracek commented Aug 25, 2023

[test-all]

@phracek phracek merged commit 1bdabcf into master Aug 25, 2023
@zmiklank zmiklank deleted the support_php_82 branch November 23, 2023 07:10
@joejoseph00
Copy link

joejoseph00 commented Mar 26, 2024

From a performance perspective, PHP 8.3 completely blows away 8.2 and all predecessors #435

@joejoseph00
Copy link

For that reason, we're looking to skip 8.2 ASAP and move directly to 8.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants