Skip to content

Conversation

@lucascolley
Copy link
Member

on top of gh-19

@lucascolley lucascolley mentioned this pull request Apr 5, 2025
6 tasks
@lucascolley lucascolley marked this pull request as ready for review April 6, 2025 10:50
@lucascolley
Copy link
Member Author

@steppi I tried following the config in SciPy, but it looks like ccache isn't having an impact here

@steppi
Copy link
Collaborator

steppi commented Apr 6, 2025

@steppi I tried following the config in SciPy, but it looks like ccache isn't having an impact here

Thanks for checking. CI time is still pretty short anyway so let's leave investigating this for the future.

@lucascolley lucascolley marked this pull request as draft April 6, 2025 14:50
@rgommers
Copy link
Member

rgommers commented Apr 7, 2025

@lucascolley conda-forge compilers set CFLAGS et al on activation, which overwrites what you put into a GHA yml file. What you seem to be missing here is env = {CC: cache $CC} in pixi.toml. See how gpu.ci.ymland the correspondingpixi.toml` in the main scipy repo are set up.

@lucascolley
Copy link
Member Author

thanks Ralf, that did the trick!

Successful in 1m

1m58s, but we'll take it :) 🚀🚀

The bottleneck now seems to be processing the .gcda files for coverage, not sure if there is a way for cache to help us there.

@lucascolley lucascolley marked this pull request as ready for review April 7, 2025 14:39
@lucascolley lucascolley requested a review from steppi April 16, 2025 13:11
@steppi
Copy link
Collaborator

steppi commented Apr 16, 2025

The failures are because there were some tests for overloads which don't actually exist in xsf and I removed the parquet files for them. The tests themselves are removed in #21. Let's just merge that one first, I'll have the tolerance files ready shortly.

@steppi
Copy link
Collaborator

steppi commented Apr 16, 2025

I merged #21. After merging main this should be ready.

@lucascolley lucascolley reopened this Apr 16, 2025
@lucascolley
Copy link
Member Author

yep, this is ready. We should see whether -j2 is any better than -j3 at some point, but that can probably wait until prefix-dev/pixi#3538 is fixed, 2 minutes is already pretty speedy

Copy link
Collaborator

@steppi steppi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thanks @lucascolley and thanks @rgommers for explaining why it wasn't working before.

@steppi steppi merged commit 778395a into scipy:main Apr 16, 2025
4 of 6 checks passed
@lucascolley lucascolley deleted the ccache branch April 16, 2025 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants