-
-
Notifications
You must be signed in to change notification settings - Fork 117
Update shortcodes #648
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Update shortcodes #648
Conversation
❌ Deploy Preview for scipy-org failed.Built without sensitive environment variables
|
Hi @goanpeca, thank you! We'll also need to ensure that all of the new shortcodes use double quotes for the values of the parameters, as single quotes are not allowed. I'm not sure how this will work with cases where we need complex multi-line content – hopefully there aren't any. |
Will make the fixes! |
2255664
to
b4f9159
Compare
Made the fixes @agriyakhetarpal ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @goanpeca! Perhaps it makes sense to update the figure, button, and image shortcodes in a consolidated PR, as one PR is better and would be easier to review than three (as I commented in https://github.com/pybamm-team/pybamm.org#283). The changes for the image shortcodes look good, though! I haven't run the website locally right now but we should confirm all pages before merging, of course.
b4f9159
to
fd04d16
Compare
c149ce2
to
eea9796
Compare
@agriyakhetarpal PRs will fix all. Some projects only use some of the shortcodes. This one has been tested :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good to me! Out of curiosity, what are the extra \
and ""
(double double quote markers) at the end of the image URLs for?
|
Hello team!
As part of figure, image and button shortcodes as being updated on this PR I created this PR to prepare the website for moving to the new syntax when a new version is released!
Pinging @agriyakhetarpal