Skip to content

Update shortcodes #648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Update shortcodes #648

wants to merge 1 commit into from

Conversation

goanpeca
Copy link
Collaborator

Hello team!

As part of figure, image and button shortcodes as being updated on this PR I created this PR to prepare the website for moving to the new syntax when a new version is released!


Pinging @agriyakhetarpal

Copy link

netlify bot commented May 20, 2025

Deploy Preview for scipy-org failed.

Built without sensitive environment variables

Name Link
🔨 Latest commit eea9796
🔍 Latest deploy log https://app.netlify.com/projects/scipy-org/deploys/68378de258ea7c00084140c3

@agriyakhetarpal
Copy link

Hi @goanpeca, thank you! We'll also need to ensure that all of the new shortcodes use double quotes for the values of the parameters, as single quotes are not allowed. I'm not sure how this will work with cases where we need complex multi-line content – hopefully there aren't any.

@goanpeca
Copy link
Collaborator Author

Hi @goanpeca, thank you! We'll also need to ensure that all of the new shortcodes use double quotes for the values of the parameters, as single quotes are not allowed. I'm not sure how this will work with cases where we need complex multi-line content – hopefully there aren't any.

Will make the fixes!

@goanpeca goanpeca force-pushed the update/shortcodes branch from 2255664 to b4f9159 Compare May 28, 2025 02:37
@goanpeca
Copy link
Collaborator Author

Made the fixes @agriyakhetarpal !

Copy link

@agriyakhetarpal agriyakhetarpal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @goanpeca! Perhaps it makes sense to update the figure, button, and image shortcodes in a consolidated PR, as one PR is better and would be easier to review than three (as I commented in https://github.com/pybamm-team/pybamm.org#283). The changes for the image shortcodes look good, though! I haven't run the website locally right now but we should confirm all pages before merging, of course.

@goanpeca goanpeca changed the title Update image shortcodes Update shortcodes May 28, 2025
@goanpeca goanpeca force-pushed the update/shortcodes branch from b4f9159 to fd04d16 Compare May 28, 2025 22:25
@goanpeca goanpeca force-pushed the update/shortcodes branch from c149ce2 to eea9796 Compare May 28, 2025 22:27
@goanpeca
Copy link
Collaborator Author

@agriyakhetarpal PRs will fix all. Some projects only use some of the shortcodes.

This one has been tested :)

Copy link

@agriyakhetarpal agriyakhetarpal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me! Out of curiosity, what are the extra \ and "" (double double quote markers) at the end of the image URLs for?

@goanpeca
Copy link
Collaborator Author

\" escapes the double quote inside a string that is using doubles quotes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants