Add language switcher and translations #617
Conversation
✅ Deploy Preview for scipy-org ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Melissa asked me to poke around on this branch a bit locally. After dealing with some issues installing Dart Sass (which is also needed on main it seems), the result for this branch of make html followed by make serve does indeed display the version switcher in top right locally:
For the most part using the switcher will swap languages and preserve the page you are navigated to when it does. One exception I noticed was that while on the "Installation" page, if you select a non-default tab like "package manager," it will always reset to the default/landing "project based" tab if you swap languages. That's pretty minor though.
Anyway, that's my initial check, hope it helps, let me know if you need anything else probed.
I don't have much to say about the infrastructure/Crowdin/auto-syncing--I'm not familiar with how that works.
| alt = 'Avatar of Nick ODell' | ||
| {{< /image >}} | ||
| Nick ODell''' | ||
| link = 'https://github.com/nickodell' |
There was a problem hiding this comment.
I think Nick recently (last 1-2 days) accepted maintainer status.
I guess that would need to be updated on main and then propagated to the language-specific versions, or something like that?
There was a problem hiding this comment.
That's right, we'll make sure to keep it up to date. The sync automation is still a bit wonky but we're working on it.
This is work in progress, as the Crowdin synchronization still needs to be set up before merging. However, you can test the switcher locally (which is why I added a copy of the website under the pt folder - this will be replaced by the actual translations once that work is finalized).
Addresses #582